fix: BROS-100: Flip rectangle regions without shift #7760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you start resizing Rectangle region from left to right flipping it and will move cursor very fast, the region will shift during flip. Konva.js Transformer has parameter `flipEnabled` which was disabled for some reason. Enabling it solves shifting issue.
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hlomzik
changed the title
|
/fmt |
Flip the height and swap top-left and bottom-left corners to keep sizes positive.
nick-skriabin
approved these changes
Jun 16, 2025
|
/git merge
|
Gondragos
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you start resizing Rectangle region from left to right effectively flipping it and if you move the cursor very fast, the region will shift during flip, because Konva.js flips rectangle sides at some point.
Konva.js Transformer has parameter
flipEnabledwhich was disabled. This parameter fixes the issue but it flips the height of the region and also rotates it at some cases.We have to fix negative height and shift the region back.
Rotation is kept intact except for the two most common cases when it stays 0:
All other cases might have rotated upside down, but sizes and position are correct, so that's acceptable.
Before:
flipping-rect-before.mov
With
flipEnabledbut without fix, notice negative height and flipped rotation:flipping-rect-negative-height.mov
After the fix, height is positive:
flipping-rect-fixed.mov