fix: LEAP-1586: Fix CommentsOverlay display without preloading image functionality #6523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, the conditions we used do not work without feature flag
fflag_feat_front_lsdv_4583_6_images_preloading_short
.But it also seems that this condition made sense only at the stage of developing the CommentsOverlay functionality. Somehow, I can't find a reason why I needed it before. So I'm removing it for the greater good.
PR fulfills these requirements
Change has impacts in these area(s)
Describe the reason for change
Comments overlay is not displayed with some feature flags states.
What alternative approaches were there?
We could change the condition to
but that leads to the blinking of all comment icons when switching pages for multi-item object tags.
Does this PR introduce a breaking change?
What level of testing was included in the change?
Which logical domain(s) does this change affect?
CommentsOverlay