Skip to content

fix: LEAP-1586: Fix CommentsOverlay display without preloading image functionality #6523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

Gondragos
Copy link
Collaborator

@Gondragos Gondragos commented Oct 15, 2024

Apparently, the conditions we used do not work without feature flag fflag_feat_front_lsdv_4583_6_images_preloading_short.

But it also seems that this condition made sense only at the stage of developing the CommentsOverlay functionality. Somehow, I can't find a reason why I needed it before. So I'm removing it for the greater good.

PR fulfills these requirements

  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Comments overlay is not displayed with some feature flags states.

What alternative approaches were there?

We could change the condition to

if (isFF(FF_LSDV_4583_6) && tag.imageIsLoaded === false) return false;

but that leads to the blinking of all comment icons when switching pages for multi-item object tags.

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

CommentsOverlay

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 114bf7e
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/670ee42576a70d00080259aa

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 114bf7e
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/670ee4255b59fd0008b7015b

@github-actions github-actions bot added the fix label Oct 15, 2024
@Gondragos Gondragos merged commit 90139c2 into develop Oct 16, 2024
37 checks passed
@Gondragos Gondragos deleted the fb-LEAP-1586/fix-comments-overlay branch October 16, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants