Skip to content

fix: LEAP-762: Fix offsets in domManager for emojis #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 1, 2024
Merged

Conversation

Gondragos
Copy link
Collaborator

@Gondragos Gondragos commented Jul 25, 2024

There were some problems with calculating offsets and applying text regions to the text/html containing emojis after domManager was introduced.

  • here it might be fixed
  • there are new tests for that
  • RichText helper for testing is introduces

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

What feature flags were used to cover this change?

N/A

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

I hope nobody would like to keep that bug.

What level of testing was included in the change?

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Text, RichText, HyperText, domManager

@github-actions github-actions bot added the test label Jul 25, 2024
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 0629753
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66aae48e2ce47a0008943ba0

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 0629753
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66aae48e3811d00008670b5a

@Gondragos Gondragos changed the title test: LEAP-762: Add tests for emojis in rich text and RichText helper fix: LEAP-762: Fix offsets in domManager for emojis Jul 25, 2024
@github-actions github-actions bot added the fix label Jul 25, 2024
@Gondragos Gondragos enabled auto-merge (squash) August 1, 2024 01:28
@Gondragos Gondragos merged commit 8d8a7fc into develop Aug 1, 2024
31 checks passed
@Gondragos Gondragos deleted the fb-leap-762 branch August 1, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants