feat: [sc-9923] Migrate @hubblehq/request to Cloud Build #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copying over from search-service as a starting point and then will customise in next commit
Remove the deployment steps as I believe this project just needs to run build and test as there are manual deployment steps.
We're moving to cloudbuild so we don't need these
There were failures because it relied on eslint being installed which is a dev dependency. The main reason we run checks against a production container is to ensure that the exact deployed environment works. Here, we only need build-and-test step as deployment is a manual process so the build isn't producing a production container (I THINK!) and so it should be ok to run tests and linting against a dev env.
oilyquack
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Please ignoring the failing Circle CI step, that's failing because circleci is required and needs to be turned off after this is merged. 😄
Also I think this project only needs a build-and-test step as the deployment is manual so there are no deployment steps in the cloudbuild.yaml file
Story details: https://app.shortcut.com/hubblehq/story/9923