Skip to content

Feature: Option to take a custom Docker image #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature: Option to take a custom Docker image #33

wants to merge 2 commits into from

Conversation

130s
Copy link

@130s 130s commented Sep 9, 2023 •
edited
Loading

Issue

  • Docker image is hardcoded but often want to use a different image.
  • ros-desktop in apt pulls in MANY packages, majority of which are simply not needed.

Related #32

130s added 2 commits September 9, 2023 14:39
@130s
Feature: Option to take Docker image
d47acbd 
Signed-off-by: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
@130s
Improve: ros-desktop is really needed?
b42a77f 
Signed-off-by: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
@130s
Copy link
Author

130s commented Sep 9, 2023

  • ros-desktop in apt pulls in MANY packages, majority of which are simply not needed.

This issue#2 may not be an issue for the project and/or many users, but I still made the change to improve it as it was an issue for me as I pointed out in #32. I'm happy to revert if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@130s