Skip to content

Conversation

mbevc1
Copy link
Contributor

@mbevc1 mbevc1 commented Jun 9, 2025

Change to maintained fork and bump version

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Jun 9, 2025
@daeho-ro
Copy link
Member

daeho-ro commented Jun 9, 2025

I think you should submit as a new formula, not changing previous one. It is not an official descendant.

@mbevc1
Copy link
Contributor Author

mbevc1 commented Jun 9, 2025

Project seems abandoned and no response from maintainers for a while. It's a in-place replacement and direct fork. Could we at least retire this and add new one? Otherwise the naming might be overlapping.

@daeho-ro
Copy link
Member

daeho-ro commented Jun 9, 2025

Here is our policy to accept forks.

@daeho-ro
Copy link
Member

daeho-ro commented Jun 9, 2025

You could add your own tap to use the same formula name, then the full name of the formula will be

brew install your-org/your-tap/aws-vault

@mbevc1
Copy link
Contributor Author

mbevc1 commented Jun 9, 2025

Thanks for the suggestion, but I'm not sure I want to maintain my own tap ATM 🤔

@mbevc1
Copy link
Contributor Author

mbevc1 commented Jun 9, 2025

What'd be suggestion in case project is dead and we cannot get updates upstream anymore?

@mbevc1
Copy link
Contributor Author

mbevc1 commented Jun 9, 2025

In case we can get a response from anyone at upstream (if maintainers will respond) I've opened: 99designs/aws-vault#1270

@mbevc1 mbevc1 changed the title aws-vault 7.3.6 aws-vault 7.3.7 Jun 10, 2025
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 10, 2025
@mbevc1 mbevc1 force-pushed the 20250609_bump_aws-vault branch from 6094a46 to 16541cc Compare June 10, 2025 11:43
@mbevc1 mbevc1 force-pushed the 20250609_bump_aws-vault branch from 16541cc to 5b02d8f Compare June 10, 2025 11:52
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 10, 2025
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 23, 2025
@BrewTestBot BrewTestBot enabled auto-merge June 23, 2025 05:19
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 23, 2025
@chenrui333
Copy link
Member

Thanks @mbevc1!

Merged via the queue into Homebrew:master with commit 50f188c Jun 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue homepage repo-location-update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants