Skip to content

wasi-runtimes: various fixes #196027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

wasi-runtimes: various fixes #196027

wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • avoid references LLVM Cellar paths in symlinks, as these will break on
    version updates to LLVM
  • make lld a test-only dependency, since it's not required at
    build-time

@carlocab carlocab force-pushed the wasi-runtimes-fixes branch 2 times, most recently from 0a69af8 to f41e9b1 Compare October 30, 2024 03:56
- avoid references LLVM Cellar paths in symlinks, as these will break on
  version updates to LLVM
- make `lld` a test-only dependency, since it's not required at
  build-time
@carlocab
Copy link
Member Author

Cherry-picked onto #195828.

@carlocab carlocab closed this Oct 30, 2024
@carlocab carlocab deleted the wasi-runtimes-fixes branch October 30, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant