Skip to content

DRAFT: FastMath Reduction #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

RyanMoser
Copy link

Replaced custom implementations of sin, cos, tan, sinCos, log1p, log10, log, exp, hypot, cbrt, pow, floor, ceil, and abs with delegates to Math

…, log, exp, hypot, cbrt, pow, floor, ceil, and abs
@maisonobe
Copy link
Contributor

I am eager to know if all Hipparchus/Orekit tests pass with this change and how the performances change.
I'll let you do some benchmarks before merging this.

@RyanMoser
Copy link
Author

@maisonobe agreed. That, and given how low-level FastMath is, I want to really make sure that these tolerance increases are definitely "o.k."

I'll see what happens in the rest of Hipparchus + Orekit approx. tomorrow morning (US, EST).

@RyanMoser RyanMoser force-pushed the FastMath_delegate_to_Math_2025-05-27 branch from 4dc13d6 to 856e3c8 Compare May 29, 2025 19:24
@RyanMoser RyanMoser mentioned this pull request May 29, 2025
@RyanMoser RyanMoser changed the title DRAFT: DRAFT: FastMath Reduction May 29, 2025
@RyanMoser
Copy link
Author

See #391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants