Skip to content

Fix crash when store list is not provided #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

HeyPouya
Copy link
Owner

Previously, the SDK expected storeList to be set by integrators and would crash if only directDownloadList was provided. This fix ensures the SDK only crashes when both storeList and directDownloadList are missing.

@HeyPouya HeyPouya requested a review from Copilot April 16, 2025 09:21
@HeyPouya HeyPouya self-assigned this Apr 16, 2025
@HeyPouya HeyPouya added the bug Something isn't working label Apr 16, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Previously, the SDK expected storeList to be set by integrators and would crash if only directDownloadList was provided.
This fix ensures the SDK only crashes when both storeList and directDownloadList are missing.
@HeyPouya HeyPouya force-pushed the fix/fix-not-passing-causes-crash branch from cee417e to 507c340 Compare April 16, 2025 09:23
@HeyPouya HeyPouya requested a review from Copilot April 16, 2025 09:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@HeyPouya HeyPouya merged commit d7da0e6 into master Apr 16, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant