Move private accessor check to field_access

[RblSb]

It merges errors like

Main.hx:70: characters 7-12 : Cannot access private field width
Main.hx:70: characters 3-12 : This property cannot be accessed for writing

Into second one. Also improves error range from obj.field to field.
Hope i check bypass_accessor correctly.

[Simn]

Let's also test all three combinations with both ++ and +=, so (public, private), (private, public) and (private, private).

Edit: I mean test that they fail properly from the outside.

[RblSb]

Is foo++ and foo += 1 should fail with private get while foo = 1 is not, as i understand?

And there is one place where i did not update position, not sure if there is example where i can see bad error pos:

haxe/src/typing/operators.ml

Lines 988 to 991 in b37c3d9

	| AKField fa ->
	let vr = new value_reference ctx in
	let ef = vr#get_expr_part "fh" fa.fa_on in
	let access_get = type_field_default_cfg ctx ef fa.fa_field.cf_name p MGet WithType.value in

[Simn]

Is foo++ and foo += 1 should fail with private get while foo = 1 is not, as i understand?

Yes that's what I would expect.

[RblSb]

Should be ready. Windows CI hanged on my test once, maybe too many errors in one file, so if it will happen again another split up can be made.

[Simn]

Ah that might be a concern with the Process API indeed. But I'll just ping you if it happens!