Skip to content

Conversation

Jaylee89
Copy link

@Jaylee89 Jaylee89 commented Sep 30, 2020

issue solve: #29

@Jaylee89
Copy link
Author

@HaujetZhao please help to merge it if no concern.

Copy link
Contributor

@pzhlkj6612 pzhlkj6612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Jaylee89 , you can remove the Virtualenv things.

Comment on lines +30 to +39
# Environments
.env
.venv
env/
venv/
ENV/
env.bak/
venv.bak/
Virtualenv/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Environments
.env
.venv
env/
venv/
ENV/
env.bak/
venv.bak/
Virtualenv/

I found that the package Virtualenv will auto add .gitignore to its directory starting from version 20.0.21, so it's unnecessary to manually ignore that directory.

v20.0.21 (2020-05-20)

Features - 20.0.21

  • Generate ignore file for version control systems to avoid tracking virtual environments by default. Users should remove these files if still want to track. For now we support only git by @ gaborbernat. (#1806)

from: https://virtualenv.pypa.io/en/20.4.2/changelog.html#features-20-0-21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants