Skip to content

chore: main image migration #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 11, 2025
Merged

chore: main image migration #1

merged 6 commits into from
Mar 11, 2025

Conversation

Harsh-Microsoft
Copy link
Owner

Purpose

This pull request includes several changes to the workflow and infrastructure configuration files. The changes primarily focus on improving the Docker build and push process, as well as updating resource parameters and variables.

Workflow Improvements:

  • .github/workflows/docker-build-and-push.yml: Modified the Docker login steps to differentiate between external and internal registries based on the branch name, and added separate steps for building and pushing Docker images to the respective registries. [1] [2] [3]

Infrastructure Configuration Updates:

  • infra/main.bicep: Updated the WebAppImageName variable to use a new container registry URL.
  • infra/main.json: Added a new environmentName parameter with validation rules and metadata, and updated the WebAppImageName variable to use the new container registry URL. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Other Information

@Harsh-Microsoft Harsh-Microsoft merged commit b41bd8b into dev Mar 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant