chore: main image migration #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes several changes to the workflow and infrastructure configuration files. The changes primarily focus on improving the Docker build and push process, as well as updating resource parameters and variables.
Workflow Improvements:
.github/workflows/docker-build-and-push.yml
: Modified the Docker login steps to differentiate between external and internal registries based on the branch name, and added separate steps for building and pushing Docker images to the respective registries. [1] [2] [3]Infrastructure Configuration Updates:
infra/main.bicep
: Updated theWebAppImageName
variable to use a new container registry URL.infra/main.json
: Added a newenvironmentName
parameter with validation rules and metadata, and updated theWebAppImageName
variable to use the new container registry URL. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information