Skip to content

Fix Lua stack corruption in window:application() when process terminated #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Lua stack corruption in window:application() when process terminated #3827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion extensions/window/libwindow.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,16 @@ static int window_application(lua_State* L) {
[skin checkArgs:LS_TUSERDATA, USERDATA_TAG, LS_TBREAK];
HSwindow *win = [skin toNSObjectAtIndex:1];
HSapplication *app = [[HSapplication alloc] initWithPid:win.pid withState:L];
[skin pushNSObject:app];
// Ensure return value is the only item on the stack to avoid leaking the receiver in coroutines
lua_settop(L, 0);
// When app is nil (process terminated), push nil directly to the caller's L
// instead of going through pushNSObject which may push to a different lua_State
// if the shared LuaSkin instance's L has been temporarily swapped by class-level logging
if (!app) {
lua_pushnil(L);
} else {
[skin pushNSObject:app];
}
return 1;
}

Expand Down