This repository was archived by the owner on Mar 29, 2022. It is now read-only.
Add error handling for GitHub 503s #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattIPv4
reviewed
Aug 20, 2020
| @@ -4,6 +4,7 @@ class ApplicationController < ActionController::Base | |||
| before_action :set_current_user | |||
| rescue_from Faraday::ClientError, with: :api_error | |||
| rescue_from Octokit::Unauthorized, with: :github_unauthorized_error | |||
| rescue_from Octokit::ServiceUnavailable, with: :api_error | |||
There was a problem hiding this comment.
Maybe we should recuse from Octokit::ServerError instead, so we cleanly handle all 5xx that GitHub might throw at us?
What do you think about handling other client errors from Octokit, or are we happy to let the app do what it does currently for those until we see an issue arrise?
There was a problem hiding this comment.
Yeah, makes sense to handle all 5xx –– let's do that.
As far as the other errors –– I wish we had more data from last year! Let me at least add Octokit::AccountSuspended, which was mentioned in #431
MattIPv4
approved these changes
Aug 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the known limitations of the GitHub API, encountered last year through 503s in the sign up process. By adding error handling for
Octokit::ServiceUnavailableexceptions, we can provide a better user experience.