Skip to content

Use the unified script to start vLLM #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2025
Merged

Conversation

taotod
Copy link

@taotod taotod commented Jun 18, 2025

Unify the DeepSeek-R1 script and revise the README

Copy link

@czhu15 czhu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
One quick question: current change only change 1 node? how about 2 node case?

@taotod
Copy link
Author

taotod commented Jun 18, 2025

Yes, only for one node. Let's revise the two node script later.

Copy link

@testdig testdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added all my comments and suggestions.

Copy link

@testdig testdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czhu15 czhu15 merged commit 3d26237 into HabanaAI:deepseek_r1 Jun 19, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants