Torch compile first call of prepare_cos_sin method #1395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kacper-Pietkun
requested review from
kzawora-intel,
madamczyk-intel,
michalkuligowski,
mgawarkiewicz-intel,
vivekgoe,
afierka-intel,
xuechendi,
jikunshang and
mswiniarsk
as code owners
|
/run-gaudi-tests |
|
/run-gaudi-tests |
|
/run-gaudi-tests |
anko-intel
reviewed
Jun 11, 2025
|
/run-gaudi-tests |
|
/run-gaudi-tests |
|
/run-gaudi-tests |
|
/run-gaudi-tests |
|
/run-gaudi-tests |
1 similar comment
|
/run-gaudi-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently prepare_cos_sin method calls inside of LlamaDecoderLayer are torch.compiled. However, first call to that method inside of HpuModelAdapter's forward runs in eager mode. This PR changes that and torch.compiles that call and fixes recompilations that were happening because of that compilation.