Support Data Parallel MOE on HPU #1022
Merged
+330
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinyu-intel
requested review from
kzawora-intel,
madamczyk-intel,
michalkuligowski,
mgawarkiewicz,
vivekgoe and
afierka-intel
as code owners
xinyu-intel
force-pushed
the
dev/xinyu/dpmoe-pr
branch
7 times, most recently
from
1b3558b to
820ad1d
Compare
xinyu-intel
force-pushed
the
dev/xinyu/dpmoe-pr
branch
3 times, most recently
from
b718e34 to
455cf52
Compare
|
/run-gaudi-tests |
1 similar comment
|
/run-gaudi-tests |
xinyu-intel
force-pushed
the
dev/xinyu/dpmoe-pr
branch
from
455cf52 to
915c389
Compare
Signed-off-by: Xinyu Chen <xichen@habana.ai>
Signed-off-by: Xinyu Chen <xichen@habana.ai>
Signed-off-by: Xinyu Chen <xichen@habana.ai>
Signed-off-by: Xinyu Chen <xichen@habana.ai>
|
/run-gaudi-tests |
|
/run-gaudi-tests |
|
@xinyu-intel , please add docstring to hacked codes in llm_engine.py, in that case, when hababa_team doing rebase, they can avoid to somehow break the DP path. |
xuechendi
reviewed
Jun 11, 2025
xuechendi
reviewed
Jun 11, 2025
xuechendi
reviewed
Jun 11, 2025
xuechendi
reviewed
Jun 11, 2025
|
@xinyu-intel , please also add UT, I think once this PR merged, it will be quite easy to get broken during rebase. |
it's hard to add UT. There is known hang issue for mix batch scenario. |
4 tasks
xuechendi
reviewed
Jun 16, 2025
xuechendi
reviewed
Jun 16, 2025
|
/run-gaudi-tests |
jikunshang
dismissed
madamczyk-intel’s stale review
upstream code do not support DP for v0 and we implement it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #947
Test CML:
PT_HPU_LAZY_MODE=1 VLLM_WORKER_MULTIPROC_METHOD=spawn VLLM_USE_V1=0 VLLM_SKIP_WARMUP=true python examples/offline_inference/data_parallel.py --model="ibm-research/PowerMoE-3b" --dp-size=2 --tp-size=2