Publish Docker images also to ACR #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having simple CD name makes it more clear in GitHub UI what workflow is being run. Also the name does not need to contain the jobs the workflow runs as that can be seen from the run details.
Previously push to any branch triggered the workflow
It was missing \n
janneronkko
force-pushed
the
acr
branch
8 times, most recently
from
e554898 to
3a88080
Compare
E2E tests do not use MSSQL Docker image, i.e. running the tests do not really test anything in the context of this repository
The old Ubuntu 16.06 requires kernel 6.6 or earlier which is not supported in GHA anymore; the oldest Ubuntu is 22.04 which currently uses kernel 6.8
janneronkko
force-pushed
the
acr
branch
7 times, most recently
from
d83650e to
e3e6ca4
Compare
The 24.04 runners do not have mssql-tools installed, i.e. we need to use the sqlcmd from, for example, the official MSSQL Docker image.
culka
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.