Add Crypto Trading Support with Multi-Environment Configs #87

feherg78 · 2025-11-06T11:49:25Z

🚀 Feature: Crypto Trading Support

This PR adds comprehensive cryptocurrency trading capabilities to AI-Trader with support for multiple deployment environments.

✨ What's New

🤖 Crypto Trading Agent

BaseAgentCrypto - Specialized agent for crypto markets
Support for derivatives trading (futures, perpetuals)
Real-time price monitoring and decision making
Multi-exchange support (ByBit, Binance, Coinbase, Kraken)

🔧 New Tools

tool_crypto_exchange.py - Exchange API integration (CCXT-based)
tool_get_price_crypto.py - Real-time price fetching
cost_tracker.py - API cost monitoring and budget tracking
environment_detector.py - Auto-detect runtime environment

🌍 Multi-Environment Support

1. Local Development (crypto_config_local.json)

TESTNET mode only (no real money)
Free GitHub Models API (gpt-4o)
Perfect for testing and development

2. GitHub Codespaces (crypto_config_codespaces.json)

90-180 hours/month free compute
Live trading with testnet option
Scheduled trading hours

3. VPS Production (crypto_config_vps.json)

24/7 live trading
Oracle Cloud Free Tier compatible
Advanced risk management
Performance monitoring and alerts

📜 Deployment Scripts

start_crypto_local.sh - Local dev startup
start_crypto_codespaces.sh - Codespaces startup
start_crypto_vps.sh - VPS production startup
deploy_oracle_vps.sh - Automated Oracle Cloud setup

🎯 AI Provider Management

Unified interface for multiple AI providers
Automatic failover between providers
Priority-based model selection
Cost tracking per provider

🔒 Risk Management Features

Position size limits
Stop-loss and take-profit automation
Trailing stop support
Daily loss limits
Emergency stop-loss

💰 Cost Optimization

Free GitHub Models API (primary)
Daily/monthly budget tracking
Alert at 80% budget threshold
Cost per trade tracking

🧪 Testing

Local development tested
Codespaces deployment pending
VPS deployment pending
Live trading not yet enabled

📋 Before Merging

Review configuration files
Test in local environment
Verify API key setup instructions
Document deployment process

🔐 Security Notes

All API keys stored in .env (gitignored)
Testnet mode enabled by default
Explicit confirmation required for live trading

Ready for review! 🚀

Copilot

Pull Request Overview

This PR adds comprehensive cryptocurrency trading capabilities to the AI-Trader system with multi-environment support and advanced infrastructure.

Key Changes:

Multi-environment detection and configuration system for local, VPS, Codespaces, and Docker deployments
Real-time API cost tracking with budget management across GitHub Models (free), Anthropic Claude, and OpenAI
Complete cryptocurrency trading agent supporting ByBit, Binance, Coinbase, and Kraken exchanges with derivatives/spot trading

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 31 comments.

Show a summary per file

File	Description
tools/environment_detector.py	Automatic runtime environment detection with platform-specific configurations
tools/cost_tracker.py	Real-time API cost tracking with per-provider monitoring and budget alerts
scripts/start_crypto_vps.sh	VPS production deployment script for 24/7 live trading
scripts/start_crypto_local.sh	Local development startup script with testnet mode
scripts/start_crypto_codespaces.sh	GitHub Codespaces-specific startup automation
scripts/deploy_oracle_vps.sh	Automated Oracle Cloud VPS deployment and initial setup
prompts/agent_prompt_crypto.py	Specialized crypto trading prompts with 24/7 market awareness
data/merge_crypto_jsonl.py	Utility to merge individual crypto JSON files into unified JSONL format
configs/crypto_config_vps.json	VPS production configuration with live trading settings
configs/crypto_config_local.json	Local development configuration with testnet defaults
configs/crypto_config_codespaces.json	GitHub Codespaces-optimized configuration
agent_tools/tool_get_price_crypto.py	MCP tool for real-time and historical crypto price queries
agent_tools/tool_crypto_exchange.py	Multi-exchange integration with unified API for trading operations
agent/providers/ai_provider_manager.py	Multi-provider AI API manager with automatic failover and rate limiting
agent/providers/init.py	Provider module initialization
agent/base_agent_crypto/base_agent_crypto.py	Advanced cryptocurrency trading agent with 24/7 support and multi-timeframe analysis
agent/base_agent_crypto/init.py	Crypto agent module initialization

Comments suppressed due to low confidence (1)

tools/environment_detector.py:43

Except block directly handles BaseException.

    except:

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-06T11:59:14Z

tools/environment_detector.py

+    return "local"
+
+
+def get_environment_config(env: Optional[str] = None) -> Dict[str, any]:


The type hint uses lowercase any instead of the proper Any type from typing. This should be Dict[str, Any] with Any imported from the typing module.

Copilot · 2025-11-06T11:59:14Z

tools/environment_detector.py

+            product = f.read().strip().lower()
+            if any(cloud in product for cloud in ["google", "amazon", "azure", "oracle", "digitalocean"]):
+                return "vps"
+    except:


Bare except clause without specifying an exception type is a bad practice. This should catch specific exceptions like IOError or FileNotFoundError to avoid silently catching unexpected errors like KeyboardInterrupt or SystemExit.

Suggested change

except:

except (FileNotFoundError, PermissionError, OSError):

Copilot · 2025-11-06T11:59:15Z

scripts/start_crypto_local.sh

+export $(cat .env | grep -v '^#' | xargs)
+


This command is vulnerable to command injection if the .env file contains malicious content. Consider using set -a; source .env; set +a or a safer method to load environment variables that doesn't execute arbitrary code through xargs.

Suggested change

export $(cat .env | grep -v '^#' | xargs)

set -a

source .env

set +a

Copilot · 2025-11-06T11:59:15Z

configs/crypto_config_vps.json

+
+  "performance_monitoring": {
+    "enabled": true,
+    "alert_email": "feherg78@example.com",


The email address "feherg78@example.com" uses the "@example.com" domain which is a reserved domain for examples. This should be replaced with a real email address or made configurable via environment variables for production use.

Suggested change

"alert_email": "feherg78@example.com",

"alert_email": "${ALERT_EMAIL}",

Copilot · 2025-11-06T11:59:15Z

data/merge_crypto_jsonl.py

+                    dt = candle['datetime']
+                    time_series[dt] = {
+                        'open': candle['open'],
+                        'high': candle['high'],
+                        'low': candle['low'],
+                        'close': candle['close'],
+                        'volume': candle['volume']


The function assumes that each candle dictionary has the keys 'datetime', 'open', 'high', 'low', 'close', and 'volume'. If any of these keys are missing, the code will raise a KeyError. Consider adding validation or using .get() with defaults for better error handling.

Suggested change

dt = candle['datetime']

time_series[dt] = {

'open': candle['open'],

'high': candle['high'],

'low': candle['low'],

'close': candle['close'],

'volume': candle['volume']

dt = candle.get('datetime')

if dt is None:

continue # skip candles without datetime

time_series[dt] = {

'open': candle.get('open', None),

'high': candle.get('high', None),

'low': candle.get('low', None),

'close': candle.get('close', None),

'volume': candle.get('volume', None)

Copilot · 2025-11-06T11:59:22Z

data/merge_crypto_jsonl.py

+from typing import List, Dict, Any
+
+


Import of 'Dict' is not used.
Import of 'List' is not used.
Import of 'Any' is not used.

Suggested change

from typing import List, Dict, Any

Copilot · 2025-11-06T11:59:22Z

agent_tools/tool_crypto_exchange.py

+
+import os
+import time
+from typing import Dict, List, Optional, Any


Import of 'Any' is not used.

Suggested change

from typing import Dict, List, Optional, Any

from typing import Dict, List, Optional

Copilot · 2025-11-06T11:59:23Z

agent_tools/tool_crypto_exchange.py

+import os
+import time
+from typing import Dict, List, Optional, Any
+from datetime import datetime


Import of 'datetime' is not used.

Suggested change

from datetime import datetime

Copilot · 2025-11-06T11:59:23Z

agent_tools/tool_get_price_crypto.py

+
+import json
+import os
+from typing import Dict, List, Optional, Any


Import of 'List' is not used.
Import of 'Optional' is not used.

Suggested change

from typing import Dict, List, Optional, Any

from typing import Dict, Any

Copilot · 2025-11-06T11:59:23Z

tools/environment_detector.py

+            product = f.read().strip().lower()
+            if any(cloud in product for cloud in ["google", "amazon", "azure", "oracle", "digitalocean"]):
+                return "vps"
+    except:


'except' clause does nothing but pass and there is no explanatory comment.

Suggested change

except:

except (FileNotFoundError, PermissionError, OSError):

# It's normal for this file to be missing or unreadable on many systems.

# In that case, we simply cannot detect a cloud provider here.

feherg78 added 2 commits November 6, 2025 12:44

Add crypto trading configs and startup scripts

c784455

Add crypto trading agent, tools, and utilities

71dbfd9

Copilot AI review requested due to automatic review settings November 6, 2025 11:49

Copilot AI reviewed Nov 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Crypto Trading Support with Multi-Environment Configs #87

Add Crypto Trading Support with Multi-Environment Configs #87

Uh oh!

feherg78 commented Nov 6, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		return "local"


		def get_environment_config(env: Optional[str] = None) -> Dict[str, any]:

	except:
	except (FileNotFoundError, PermissionError, OSError):

	"alert_email": "feherg78@example.com",
	"alert_email": "${ALERT_EMAIL}",

	from typing import Dict, List, Optional, Any
	from typing import Dict, List, Optional

	from typing import Dict, List, Optional, Any
	from typing import Dict, Any

-    except:
+    except (FileNotFoundError, PermissionError, OSError):
+        # It's normal for this file to be missing or unreadable on many systems.
+        # In that case, we simply cannot detect a cloud provider here.

Add Crypto Trading Support with Multi-Environment Configs #87

Are you sure you want to change the base?

Add Crypto Trading Support with Multi-Environment Configs #87

Uh oh!

Conversation

feherg78 commented Nov 6, 2025

🚀 Feature: Crypto Trading Support

✨ What's New

🤖 Crypto Trading Agent

🔧 New Tools

🌍 Multi-Environment Support

📜 Deployment Scripts

🎯 AI Provider Management

🔒 Risk Management Features

💰 Cost Optimization

🧪 Testing

📋 Before Merging

🔐 Security Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant