feat/add slowlog command #254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDT3213
requested changes
Jun 29, 2025
| // SlowLogger Slow query logger | ||
| type SlowLogger struct { | ||
| mu sync.RWMutex | ||
| entries *list.List // 日志链表 |
| // 记录一个慢查询 | ||
| start := time.Now() | ||
| time.Sleep(2 * time.Millisecond) // 确保超过阈值 | ||
| logger.Record(start, [][]byte{[]byte("GET"), []byte("key1")}, "127.0.0.1:12345") |
|
|
||
| exec := selectedDB.Exec(c, cmdLine) | ||
| // Record slow query logs | ||
| server.slogLogger.Record(GodisExecCommandStartUnixTime, cmdLine, c.Name()) |
There was a problem hiding this comment.
GodisExecCommandStartUnixTime 为什么要搞成全局变量？在 Exec 函数里加个局部变量不是已经够用了？而且 godis 内核是并行的，这么搞全局变量不会出错吗？
|
好的， 我修改一下。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'slowlog-log-slower-than' and 'slowlog-max-len', have been added to the configuration file.