Implement Many, Many Game GUI Controls #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds a helper to ensure that MRO works correctly for mixin classes. There are a few places in PlasmaModifierProperties where type hints are commented out because of this. We should go back and apply this helper for that.
Radio Groups currently need to be a dedicated object. A radio group is intangible, so an empty is a good choice for that, IMO.
This is two components in PlasmaMax... The edit box and multi line edit box. IMO, the two are almost identical, so it's best to use one modifier and just add a single or multi line flag.
I'm not 100% sure what the difference is between DragBar and Draggable is in terms of when and how they are used. Draggables have some extra reporting features and can be used by buttons. Unfortunately, there is only *one* Draggable in all of Uru... the pod map in the Ae'gura Museum, and it's not a draggable button. Even though I don't quite understand how it all fits together, I think it's fine to simply add the support - this Game GUI stuff is still all explicitly "experimental," so here be dragons, yo.
I've already had to rewrite history once because I was fetching controls on the wrong objects. So, let's remove that footgun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds enough GUI controls to really do some damage.
Add:
pfGUIClickMapCtrl)pfGUICheckBoxCtrl)pfGUIDragBarCtrl,pfGUIDraggableMod)pfGUIColorScheme- not actually a GUI control)pfGUITextBoxMod)pfGUIRadioGroupCtrl)pfGUIDynDisplayCtrl)pfGUIProgressCtrl)pfGUIValueCtrl- ABC)pfGUIEditBoxMod,pfGUIMultiLineEditCtrl)Game GUI support is still experimental, meaning all of these controls are subject to change without warning or concern for backwards compatibility.
After these are merged, we will only lack:
pfGUIKnobCtrlpfGUIListBoxModpfGUIPopUpMenupfGUIUpDownPairModThis PR will be merged soon. If anyone has any feedback, give it ASAP.