CMS 6 compatibility. #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Form::validate() now handles this directly, so we can't change that functionality by replacing a single validator anymore.
- `GridFieldMessagesExtension` is no longer relevant because the bug it was working around was fixed. - `DataObjectDefaultAjaxExtension` is no longer relevant because the `new` keyword is no longer used for instantiating composite validators, so we can rely on injector config now.
- Update FQCN for classes that moved - Improve typehinting - Remove unnecessary phpdocs - Some minor code quality improvements
GuySartorelli
commented
Apr 11, 2025
GuySartorelli
commented
Apr 11, 2025
This doesn't really add anything that isn't part of the one that comes with framework anymore. The main reason for this was to avoid double validation of fields, but that's not a problem in framework anymore.
GuySartorelli
force-pushed
the
cms6
branch
2 times, most recently
from
2494175 to
f0d5fa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings this module into compatibility with CMS 6.
Breaking changes include:
RegexFieldsValidatorremoved. UseConstraintsValidatorwith aRegexconstraint instead.SimpleFieldsValidatorremoved.Form::validate()will callFormField::validate()without the need for an additional validator. SeeAjaxCompositeValidatordocs for how to omit fields from AJAX validation.RequiredFieldsValidatorremoved - use theRequiredFieldsValidatorfrom framework instead.GridFieldMessagesExtensionremoved as it's no longer necessary.DataObjectDefaultAjaxExtensionremoved - use injector configuration instead.FormFieldExtensionremoved - we can't control whenvalidate()is called on fields anymore, since that's happening directly in the form.protectedso can't be called directly on the object being extended