Da/config loading #650
Merged
Da/config loading #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aligns and normalizes loading states across payroll configuration and overview components. The changes introduce consistent loading indicators and UI patterns across different payroll flow stages.
- Updated loading indicator components to support custom children content
- Modified payroll configuration and overview to use standardized loading states with custom messaging
- Removed back button functionality from payroll configuration and cleaned up unused exports
Reviewed Changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/i18n/en/Payroll.PayrollOverview.json | Added loading state translations and wrapped date display in formatting component |
| src/i18n/en/Payroll.PayrollConfiguration.json | Updated page structure, added loading translations, and removed back button text |
| src/contexts/LoadingIndicatorProvider/useLoadingIndicator.tsx | Enhanced LoadingIndicator to accept children props |
| src/components/Payroll/usePreparedPayrollData.ts | Integrated baseSubmitHandler for consistent loading behavior |
| src/components/Payroll/index.ts | Removed unused RunPayrollFlow export |
| src/components/Payroll/PayrollOverview/PayrollOverviewPresentation.tsx | Added loading state UI and improved date formatting with Trans component |
| src/components/Payroll/PayrollEditEmployee/PayrollEditEmployee.tsx | Integrated baseSubmitHandler for consistent form submission |
| src/components/Payroll/PayrollConfiguration/PayrollConfigurationPresentation.tsx | Major refactor to add loading states, remove back button, and improve layout structure |
| src/components/Payroll/PayrollConfiguration/PayrollConfigurationPresentation.test.tsx | Updated tests to reflect removed back button functionality |
| src/components/Payroll/PayrollConfiguration/PayrollConfiguration.tsx | Enhanced polling logic and integrated loading states |
| src/components/Payroll/PayrollConfiguration/PayrollConfiguration.stories.tsx | Removed back button from story configuration |
| src/components/Common/Loading/Loading.tsx | Enhanced Loading component to support children content |
| src/components/Common/Loading/Loading.stories.tsx | Added story for Loading component with children |
| src/components/Common/Loading/Loading.module.scss | Added styling for centered content within loading component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/components/Payroll/PayrollConfiguration/PayrollConfigurationPresentation.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
serikjensen
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligning and normalizing loading state for configuration and overview components:
Screen.Recording.2025-10-08.at.5.50.40.PM.mov