fix: Apollo Federated Tracing (ftv1) with Apollo Router #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g `expect { value }.to raise /The _entities resolver tried to load an entity for type "TypeNotInSchema"/` not `expect(value).to raise /The _entities resolver tried to load an entity for type "TypeNotInSchema"/`
```
Apollo Router isn't reporting federated trace data to Apollo Studio when using `Base64.encode64`, which uses newlines, but does when using strict encoding which doesn't use newlines.
cgriego
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Apollo Federated tracing functionality with Apollo Router, Apollo Router did not report the subgraph tracing data to Apollo Studio. Based on #29 which claims the tracing should use
Base64.strict_encode64so that in JS / Apollo Gateway the decoding is faster, I tried using it with Router and after Router would successfully report the trace data to Apollo Studio.