Use std TryFrom trait #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2021
GuillaumeGomez
approved these changes
Mar 5, 2021
|
It just reminds me how old this project is everytime haha. Thanks for the PR! |
|
I published your change. |
|
I saw, thanks for the quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rust-lang/rust#82781, I'm trying to experiment what we might run into if
TryFrom/TryInto/FromIteratorare added to the prelude. It turns out the compiler build itself fails because method calls in minifier become ambiguous. At some point we will havecargo fixlints to make this easier, but for now doing this manually was easy enough.Would be nice to get a new release out so that the compiler can pick that up.