Skip to content

Conversation

leoguignard
Copy link
Member

A small PR to maybe faster your work.

Small note:
Everywhere there is something like that:

Literal["max", "sum", None] = "max"

Why do we need to have None in the possibilities?
(before it was Literal["max", "sum"] | None = "max" which is the same.

@leoguignard leoguignard requested a review from BadPrograms May 20, 2025 11:00
@BadPrograms
Copy link
Collaborator

I think its easy to return and may be useful to people.
Do you want to make it Literal["max","sum"]|None?

@leoguignard
Copy link
Member Author

It was Literal["max","sum"] | None I made it Literal["max","sum", None]. The question is can it be Literal["max","sum"]?

@BadPrograms
Copy link
Collaborator

No i want to have the none

@leoguignard
Copy link
Member Author

What does None mean? If it means "no normalisation" then probably something less ambiguous could be better. Example: "identity" or "none" but not accepting None since it has a specific meaning.

@leoguignard leoguignard merged commit 8bec0dd into uted_backtrace_dev May 20, 2025
1 check passed
@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (1998748) to head (ecd7cea).
Report is 3 commits behind head on uted_backtrace_dev.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           uted_backtrace_dev      #72      +/-   ##
======================================================
- Coverage               96.39%   96.38%   -0.02%     
======================================================
  Files                       2        2              
  Lines                     305      304       -1     
  Branches                   14       15       +1     
======================================================
- Hits                      294      293       -1     
  Misses                      6        6              
  Partials                    5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BadPrograms BadPrograms deleted the to_backtrace branch June 16, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants