Skip to content

Add Simon Game project by Tanmita Roy #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Tr1120
Copy link

@Tr1120 Tr1120 commented Apr 24, 2025

Added a memory game built with JS, HTML, CSS, and jQuery

Copy link

👋 @Tr1120
Thank you for raising your pull request.
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

@iamwatchdogs
Copy link
Contributor

Hi @Tr1120, Thank you for making this PR to contribute to this repo with your wonderful project. As the lining checks have passed, please wait till I review your source code.

Copy link
Contributor

@iamwatchdogs iamwatchdogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your PR @Tr1120, I can conclude that you have copied and pasted your project within to make this PR, which is totally fine in the novice stage.

But I can see there's an unnecessary level of file hierarchy within you PR which might not go well within the final contribution table which are automated to update based on your contribution.

Changes Required

Please make the following changes to proceed further.

  • Remove the redundant hierarchy as follows...
Current File Structure Desired File structure
simon-game
├── README.md
└── SimonGame-main
    ├── index.html
    ├── index.js
    ├── README.md
    ├── sounds
    └── styles.css
simon-game
├── index.html
├── index.js
├── README.md
├── sounds
│   ├── blue.mp3
│   ├── green.mp3
│   ├── red.mp3
│   ├── wrong.mp3
│   └── yellow.mp3
└── styles.css

@Tr1120 Tr1120 closed this Apr 25, 2025
Copy link

👋 @Tr1120 This PR is closed. If you think there's been a mistake, please contact the maintainer @iamwatchdogs.

@Tr1120 Tr1120 reopened this Apr 25, 2025
@Tr1120
Copy link
Author

Tr1120 commented Apr 25, 2025

File structure changed into required structure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants