Skip to content

Created a Blend mode on hero section #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Created a Blend mode on hero section #30

wants to merge 2 commits into from

Conversation

Inija-2503
Copy link
Contributor

Hi i have created a animation of blending text and video on hero section which makes user have realistic experience
check out the video how it is. I am open for any sort of suggestion.

blend.mode.mp4

@github-actions github-actions bot added the hacktoberfest Opted for hacktoberfest label Oct 25, 2024
Copy link

👋 @Inija-2503
Thank you for raising your pull request.
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

@iamwatchdogs
Copy link
Contributor

iamwatchdogs commented Oct 25, 2024

Hi @Inija-2503, that's a great contribution and as I can see you have also made the PR from another branch exactly as instructed. But there's a slight problem...

Problem

You made a mistake by not creating the new branch from the main branch. This is a problem because the first PR you have made i.e., PR #29 was created from Tourism branch. And I believe that you have created another branch (i.e., blend-mode ) from the Tourism branch.

If you believed how this could affect your contribution, then view the following screenshots...

Files present within PR #29 Files present within this PR
image image

As you can see the screenshots, all the previous commits made within Tourism branch i.e., from PR #29 are present within this PR. And If I merge this PR first then the other PR would become invalid as the changes you're trying to make already be present by then, thus making that PR inadmissible.

Solution

Here's my proposed solution for this issue,

  • Close this PR.

  • Delete the blend-mode branch (both from your local repo and from remote i.e., github repo).

    # this will delete the branch all the contents within branch,
    # so make sure you have all the file content backuped before you do this
    git branch -D blend-mode
  • Update the main branch within you remote/github repo as showen below,

    image

  • Checkout to main branch.

    git checkout main
  • Pull the latest changes into your main branch.

    git pull origin main
  • Create a new branch and checkout to it, maybe with the same name or different name (totally upto you).

    git checkout -b <new-branch-name>
  • Commit and push your Changes.

    # adding the project or other changes
    git add .
    
    # committing the changes
    git commit -m "commit message"
    
    # pushing the changes
    git push origin <new-branch-name>
  • Create a PR.

Then I'll let your merge the PR into the repo.

Important

If you need any help in any of the process (or) if you did understand any part of the solution I proposed, please ping me up here. Please don't take action based on some assumption. Feel free to ask me questions and doubts, I would be more than happy to help.

@Inija-2503 Inija-2503 closed this Oct 25, 2024
@Inija-2503 Inija-2503 deleted the blend-mode branch October 25, 2024 14:32
Copy link

👋 @Inija-2503 This PR is closed. If you think there's been a mistake, please contact the maintainer @iamwatchdogs.

@github-actions github-actions bot added the hacktoberfest-accepted Successfully accepted pull request for hacktoberfest label Oct 25, 2024
@Inija-2503 Inija-2503 mentioned this pull request Oct 25, 2024
@iamwatchdogs iamwatchdogs added invalid This doesn't seem right and removed hacktoberfest-accepted Successfully accepted pull request for hacktoberfest labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Opted for hacktoberfest invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants