This repository was archived by the owner on Jan 9, 2024. It is now read-only.
Do not attempt to disconnect if there's no connection #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another case of Grokzen#453 There are cases in which we can get a `BaseException` before we have established a connection, which means that attempting to disconnect from it will result in an unhandled exception.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another case of
#453 . I'm not sure I have the ability to reopen issues but this should be the fix.
There are cases in which we can get a
BaseExceptionbefore we haveestablished a connection, which means that attempting to disconnect from
it will result in an unhandled exception.