-
-
Notifications
You must be signed in to change notification settings - Fork 151
Punctuation: Don't put spaces around the slash when denoting single-word alternatives: one/two instead of one / two #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
An-anonymous-coder
wants to merge
13
commits into
GrapheneOS:main
Choose a base branch
from
An-anonymous-coder:patch-4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ord alternatives: one/two instead of one / two Updated for `USB-C/pogo pins` and `privacy/security`
…ord alternatives: one/two instead of one / two Updated for `modified/corrupted data`
…ord alternatives: one/two instead of one / two Changed for `modified/corrupted data`
…ord alternatives: one/two instead of one / two Changed for: `libraries/services` `hardware/firmware` `boot/attestation` `generic/other` `Open/close` `tag/branch` `definitions/statements`
…ord alternatives: one/two instead of one / two Changed for: locked/idle noisy/silent VPN/Tor Firefox/Gecko QR/barcode images/record configuration/tuning VoLTE/VoWi-Fi calls/texts authentication/encryption downloaded/updated app/content GNSS/A-GPS integration/control wired/wireless
…ord alternatives: one/two instead of one / two Changed for: encode/decode ext4/f2fs certificate/key carrier/network communications/data query/data NTP/SNTP query/data network/user subscriptions/rules MTP/PTP MTP/PTP project/organization
…ord alternatives: one/two instead of one / two PLEASE REVIEW 2021.08.03.03 RELEASE NOTES Review and change `GmsCompat/ prefix` to `GmsCompat/prefix` if that was what was intended. I did not change this. INTERACT_ACROSS_USERS/INTERACT_ACROSS_USERS_FULL Storage Scopes/Contact Scopes 10 minutes/5 minutes 60 minutes/30 minutes images/updates hardened_malloc/bionic UX/error checking complete/generic IMSI/Phone number installing/updating Play services/Play Store history/indicator RSA 4096/sha256 AOSP/stock OS annotations/exceptions AOSP/stock OS AOSP/stock OS AOSP/stock OS AOSP/stock OS AOSP/stock OS robust/future AOSP/stock OS AOSP/stock OS A bunch more `AOSP / stock OS` -> `AOSP/stock OS` that I replaced all instances of automatically file/directory returning/disposing basic/quick firmware/device AOSP/stock Pixel OS quality/robustness flash-all.sh/flash-all.bat APN/carrier APN/carrier code/functionality infrastructure/shims failure/success connectivity check/captive portal compatibility/testing 4/4 XL experimental/hidden protected_fifos/protected_regular device/generation generating/uploading supported/tested supported/tested Chromium/Chrome performance/hardening
…ord alternatives: one/two instead of one / two Changed `MIT/Apache 2`. Make sure the link still works.
…ord alternatives: one/two instead of one / two Changed `ads.txt/app-ads.txt` This may cause confusion as it unintentionally implies ads.txt is a directory.
…ord alternatives: one/two instead of one / two system calls/context switches
…ord alternatives: one/two instead of one / two ads.txt/app-ads.txt ads.txt/app-ads.txt buying/selling ads.txt/app-ads.txt May unintentionally imply ads.txt is a directory
…ord alternatives: one/two instead of one / two support/device support/features copies/versions Connectivity check/time server
thestinger
requested changes
Mar 19, 2025
94b3e0a
to
5e9a775
Compare
fecb474
to
15c1540
Compare
dff6203
to
f07363a
Compare
53db6ca
to
3495649
Compare
89645e4
to
c13cc05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #285
Review 2021.08.03.03 release notes and change
GmsCompat/ prefix
toGmsCompat/prefix
if that was what was intended. I did not change this.I did not change anything in the legacy changelog, but I can if you want me to.
Make sure the link for Auditor still works under the Attestation Compatibility Guide article.
Review Articles index page and Sitewide Advertising Industry page for potential confusion.