Add the support of group by for metric to Arithmetic

[sunnut]

• If metric A & B has group by, the Output Name not work
• If metric A & B has no group by, the Order and Size not work

[Gauravshah]

fixes #14

[sunnut]

@Gauravshah @ShilpaSivanesan
A pic to show the group by support.

[keithkml]

I would love to use this feature. When do you expect the code review will be complete?

[ShilpaSivanesan]

@sunnut Thanks for the contribution
I tried this with the druid data source, it doesn't seem to work as expected
Also, the PR refers always 2 group by metrics, will it work when arithmetic applied to single group by metric?

[sunnut]

@ShilpaSivanesan

1. If the metric just have the time group by, it worked as before.
   2.I add the group by ability for metric besides time to arithmetic.
   Pls try again as the pic following:
   

[Foorth]

Hi @Gauravshah

Any news here? This pull request is very relevant to me.

[Gauravshah]

@Foorth the PR had bugs and we did not invest in it. we are open to contribution but are not actively working on this issue

[sunnut]

Hi, @Gauravshah I have tried it on my product(db used elasticsearch) and work as expected.
I didnot find the bug you mentioned.
I will test it using other type datasource.

[rasinhas]

This code is not working as intended when you pick "No limit" as your group by size.

Suggested change

	if (orderSize > resultsTotalList.length) {
	if (orderSize > resultsTotalList.length || orderSize == 0) {

This should fix it.

[rasinhas]

Other than this it seems to be working as intended to me (I'm using it only on elasticsearch datasource)

[sunnut]

Yeah，I have fixed the bug in my project.

[rasinhas]

This code makes it impossible to save an arithmetic metric with orderSize 'no limit' (id == 0).

[sunnut]

This bug also fixed by !this.target.orderSize && this.target.orderSize !== 0

[Gauravshah]

@rasinhas can you raise another PR after fixing it ?