Skip to content

Remove python 3.7 #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 9, 2024
Merged

Remove python 3.7 #358

merged 6 commits into from
Aug 9, 2024

Conversation

GoogolGenius
Copy link
Owner

@GoogolGenius GoogolGenius commented Aug 9, 2024

Summary by Sourcery

Remove support for Python 3.7 from the project, including updates to the CI workflow and documentation to reflect the new minimum supported Python version of 3.8.

CI:

  • Remove Python 3.7 from the GitHub Actions lint workflow matrix.

Documentation:

  • Update README and documentation to reflect compatibility with Python 3.8+ instead of Python 3.7+.

Copy link
Contributor

sourcery-ai bot commented Aug 9, 2024

Reviewer's Guide by Sourcery

This pull request removes support for Python 3.7 from the project. The changes include updating the GitHub Actions workflow to exclude Python 3.7 from the testing matrix and setting the default Python version to 3.12. Additionally, the documentation has been updated to reflect that the project is now compatible with Python 3.8+.

File-Level Changes

Files Changes
README.md
docs/index.md
Updated documentation to reflect the removal of support for Python 3.7, indicating compatibility with Python 3.8+.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@GoogolGenius GoogolGenius merged commit 502969f into main Aug 9, 2024
11 checks passed
@GoogolGenius GoogolGenius deleted the detail/lib branch August 9, 2024 05:51
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GoogolGenius - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant