Skip to content

Conversation

Deepraj1996
Copy link

No description provided.

@Deepraj1996 Deepraj1996 requested review from a team, ayushmjain, q2w and qz267 as code owners August 25, 2025 08:30
Copy link

google-cla bot commented Aug 25, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

type = string
}

variable "region" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can directly provided in the main.tf

description = "Project ID of the service"
}

output "service_name" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can directly use the value in the test file. Let's not introduce these output vars here

description = "Name of the created service"
}

output "service_region" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

| Name | Description |
|------|-------------|
| backend\_service\_info | Host, path and backend service mapping |
| project\_id | Project ID of the service |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These output variables are not needed.

- backend_service: string
host: string
path: string
- name: project_id
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These outputs are not needed.

]
}

output "project_id" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These output variables are not needed.

backendServiceWithIAP.DefineVerify(func(assert *assert.Assertions) {

projectID := backendServiceWithIAP.GetTFSetupStringOutput("project_id")
serviceName := backendServiceWithIAP.GetStringOutput("service_name")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can directly use service_name and service_region values here

- name: service_name
description: Name of the created service
- name: service_region
description: Region in which the service is created
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run make generate_docs to update the roles and services requirement in the metadata.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants