-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Added IAP Enablement and Principal Management on Regional-lb-http backend-services #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
type = string | ||
} | ||
|
||
variable "region" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can directly provided in the main.tf
description = "Project ID of the service" | ||
} | ||
|
||
output "service_name" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can directly use the value in the test file. Let's not introduce these output vars here
description = "Name of the created service" | ||
} | ||
|
||
output "service_region" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
| Name | Description | | ||
|------|-------------| | ||
| backend\_service\_info | Host, path and backend service mapping | | ||
| project\_id | Project ID of the service | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These output variables are not needed.
- backend_service: string | ||
host: string | ||
path: string | ||
- name: project_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These outputs are not needed.
] | ||
} | ||
|
||
output "project_id" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These output variables are not needed.
backendServiceWithIAP.DefineVerify(func(assert *assert.Assertions) { | ||
|
||
projectID := backendServiceWithIAP.GetTFSetupStringOutput("project_id") | ||
serviceName := backendServiceWithIAP.GetStringOutput("service_name") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can directly use service_name and service_region values here
- name: service_name | ||
description: Name of the created service | ||
- name: service_region | ||
description: Region in which the service is created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run make generate_docs
to update the roles and services requirement in the metadata.yaml
No description provided.