Skip to content

fix(retail): add region tag for Python - search with query expansion spec #13464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(retail): add region tag for Python - search with query expansion spec #13464

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
afda83b
Update search_with_pagination.py
rebeccaellis Jun 11, 2025
ae4dbe6
Merge pull request #1 from rebeccaellis/rebeccaellis-patch-search-wit…
rebeccaellis Jun 11, 2025
f3f1908
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 12, 2025
9ae34ea
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 17, 2025
96bea44
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 27, 2025
18d3c6e
Update search_with_query_expansion_spec.py
rebeccaellis Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions retail/interactive-tutorials/search/search_with_query_expansion_spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# Call Retail API to search for a products in a catalog,
# enabling the query expansion feature to let the Google Retail Search build an automatic query expansion.
#

# [START retail_search_for_products_with_query_expansion_specification]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The region tag name retail_search_for_products_with_query_expansion_specification is verbose. For better consistency with other samples like search_simple_query.py which uses retail_search_simple_query, consider a more concise tag name that reflects the filename, such as retail_search_query_expansion_spec.

Suggested change
# [START retail_search_for_products_with_query_expansion_specification]
# [START retail_search_query_expansion_spec]

import google.auth
from google.cloud.retail import SearchRequest, SearchServiceClient

Expand Down Expand Up @@ -62,6 +62,6 @@ def search():
else:
print(search_response)
return search_response

# [END retail_search_for_products_with_query_expansion_specification]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the START tag, update this END tag to match the suggested shorter name. A name derived directly from the filename improves maintainability.

Suggested change
# [END retail_search_for_products_with_query_expansion_specification]
# [END retail_search_query_expansion_spec]


search()