-
Notifications
You must be signed in to change notification settings - Fork 6.6k
fix(retail): add region tag for Python - search with query expansion spec #13464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rebeccaellis
wants to merge
6
commits into
GoogleCloudPlatform:main
Choose a base branch
from
rebeccaellis:rebeccaellis-search-with-query-expansion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2
−2
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
afda83b
Update search_with_pagination.py
rebeccaellis ae4dbe6
Merge pull request #1 from rebeccaellis/rebeccaellis-patch-search-wit…
rebeccaellis f3f1908
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis 9ae34ea
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis 96bea44
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis 18d3c6e
Update search_with_query_expansion_spec.py
rebeccaellis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ | |
# Call Retail API to search for a products in a catalog, | ||
# enabling the query expansion feature to let the Google Retail Search build an automatic query expansion. | ||
# | ||
|
||
# [START retail_search_for_products_with_query_expansion_specification] | ||
import google.auth | ||
from google.cloud.retail import SearchRequest, SearchServiceClient | ||
|
||
|
@@ -62,6 +62,6 @@ def search(): | |
else: | ||
print(search_response) | ||
return search_response | ||
|
||
# [END retail_search_for_products_with_query_expansion_specification] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
search() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The region tag name
retail_search_for_products_with_query_expansion_specification
is verbose. For better consistency with other samples likesearch_simple_query.py
which usesretail_search_simple_query
, consider a more concise tag name that reflects the filename, such asretail_search_query_expansion_spec
.