-
Notifications
You must be signed in to change notification settings - Fork 2k
sql_user
: improve docs for password_wo
argument
#15382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BBBmau
wants to merge
3
commits into
GoogleCloudPlatform:main
Choose a base branch
from
BBBmau:doc-fix-sql-user-password-wo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -12,6 +12,8 @@ Creates a new Google SQL User on a Google SQL User Instance. For more informatio | |||||
[Read more about sensitive data in state](https://www.terraform.io/language/state/sensitive-data). Passwords will not be retrieved when running | ||||||
"terraform import". | ||||||
|
||||||
-> **Note:** Write-Only argument `password_wo` is available to use in place of `password`. Write-Only argumentss are supported in HashiCorp Terraform 1.11.0 and later. [Learn more](https://developer.hashicorp.com/terraform/language/resources/ephemeral#write-only-arguments). | ||||||
|
||||||
## Example Usage | ||||||
|
||||||
Example creating a SQL User. | ||||||
|
@@ -117,6 +119,15 @@ The following arguments are supported: | |||||
or CLOUD_IAM_SERVICE_ACCOUNT. Don't set this field for CLOUD_IAM_USER | ||||||
and CLOUD_IAM_SERVICE_ACCOUNT user types for any Cloud SQL instance. | ||||||
|
||||||
* `password_wo` - (Optional, write-only) The password for the user. Can be updated. For Postgres | ||||||
instances this is a Required field, unless type is set to either CLOUD_IAM_USER | ||||||
or CLOUD_IAM_SERVICE_ACCOUNT. Don't set this field for CLOUD_IAM_USER | ||||||
and CLOUD_IAM_SERVICE_ACCOUNT user types for any Cloud SQL instance. | ||||||
|
||||||
* ~> **Note:** One of `value` or `value_wo` can only be set. | ||||||
|
||||||
* `password_wo_version` - (Optional) An integer value used to trigger an update for `password_wo`. This property should be incremented when updating `password_wo`. For more info see [updating write-only attributes](/docs/providers/google/guides/using_write_only_attributes.html#updating-write-only-attributes). | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe this should also be a doc on: updating write only arguments? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
* `type` - (Optional) The user type. It determines the method to authenticate the | ||||||
user during login. The default is the database's built-in user type. Flags | ||||||
include "BUILT_IN", "CLOUD_IAM_USER", "CLOUD_IAM_SERVICE_ACCOUNT", "CLOUD_IAM_GROUP", | ||||||
|
@@ -130,8 +141,6 @@ The following arguments are supported: | |||||
|
||||||
Possible values are: `ABANDON`. | ||||||
|
||||||
* `password_wo_version` - (Optional) The version of the password_wo. For more info see [updating write-only attributes](/docs/providers/google/guides/using_write_only_attributes.html#updating-write-only-attributes). | ||||||
|
||||||
- - - | ||||||
|
||||||
* `host` - (Optional) The host the user can connect from. This is only supported | ||||||
|
@@ -157,16 +166,6 @@ The read only `password_policy.status` subblock supports: | |||||
|
||||||
* `password_expiration_time` - (read only) Password expiration duration with one week grace period. | ||||||
|
||||||
## Ephemeral Attributes Reference | ||||||
|
||||||
The following write-only attributes are supported: | ||||||
|
||||||
* `password_wo` - (Optional) The password for the user. Can be updated. For Postgres | ||||||
instances this is a Required field, unless type is set to either CLOUD_IAM_USER | ||||||
or CLOUD_IAM_SERVICE_ACCOUNT. Don't set this field for CLOUD_IAM_USER | ||||||
and CLOUD_IAM_SERVICE_ACCOUNT user types for any Cloud SQL instance. | ||||||
**Note**: This property is write-only and will not be read from the API. | ||||||
|
||||||
## Attributes Reference | ||||||
|
||||||
Only the arguments listed above are exposed as attributes. | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT, for the rest LGTM!