Acceptance test for vmware engine network, networkpeering, networkpol…

[amithkumar-s]

…icy, privatecloud

vmwareengine: added `tags` field to the `google_vmwareengine_network`, `google_vmwareengine_network_peering`, `google_vmwareengine_network_policy`, and `google_vmwareengine_private_cloud` resources

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[SirGitsalot]

The gofmt check can be fixed by running:

gofmt -w mmv1/third_party/terraform/services/vmwareengine/resource_vmwareengine_network_peering_test.go
gofmt -w mmv1/third_party/terraform/services/vmwareengine/resource_vmwareengine_network_policy_test.go
gofmt -w mmv1/third_party/terraform/services/vmwareengine/resource_vmwareengine_network_test.go
gofmt -w mmv1/third_party/terraform/services/vmwareengine/resource_vmwareengine_private_cloud_test.go

The CLA check is a little bit more work. You'll need your manager and/or Google contact to follow the steps at go/github-docs/access/tvc.

Everything else looks good. I started the test run, if that passes the PR should be good to go once the two failing checks are addressed (there's actually three failing checks, but I'm going to fix one of them right now).

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 875 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 19 files changed, 875 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 68 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vmwareengine_network_policy (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vmwareengine_network_policy" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 7
Skipped tests: 5
Affected tests: 4

Click here to see the affected service packages

• vmwareengine

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccVmwareengineNetworkPeering_tags
• TestAccVmwareengineNetworkPolicy_tags
• TestAccVmwareengineNetwork_tags
• TestAccVmwareenginePrivateCloud_tags

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccVmwareengineNetworkPeering_tags [Error message] [Debug log]
TestAccVmwareengineNetworkPolicy_tags [Error message] [Debug log]
TestAccVmwareengineNetwork_tags [Error message] [Debug log]
TestAccVmwareenginePrivateCloud_tags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test