-
Notifications
You must be signed in to change notification settings - Fork 2k
Added support for TransferManifest option in TransferSpec for google_storage_transfer_job #15367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing doc report (experimental)The following resources have fields missing in documents.
|
Tests analyticsTotal tests: 18 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 18 Click here to see the affected service packages
🟢 All tests passed! View the build log |
AwsS3CompatibleDataSource: expandAwsS3CompatibleData(transferSpec["aws_s3_compatible_data_source"].([]interface{})), | ||
} | ||
|
||
if v, ok := transferSpec["transfer_manifest"].([]interface{}); ok && len(v) > 0 && v[0] != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the need of this block? We already have appropriate validations in the field schema declaration which can handle these cases beforehand.
Added support for TransferManifest option in TransferSpec for google_storage_transfer_job
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.