Skip to content

Conversation

malhotrasagar2212
Copy link
Collaborator

@malhotrasagar2212 malhotrasagar2212 commented Oct 13, 2025

Added support for TransferManifest option in TransferSpec for google_storage_transfer_job

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

storagetransfer: added `transfer_manifest` field to `google_storage_transfer_job` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 167 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 167 insertions(+), 1 deletion(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_storage_transfer_job
    • Expected Document Path: /website/docs/r/storage_transfer_job.html.markdown
    • Fields: [transfer_spec.transfer_manifest transfer_spec.transfer_manifest.location]

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • storagetransfer

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageTransferJob_transferManifest

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccStorageTransferJob_transferManifest [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 178 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 178 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 18
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • storagetransfer

🟢 All tests passed!

View the build log

AwsS3CompatibleDataSource: expandAwsS3CompatibleData(transferSpec["aws_s3_compatible_data_source"].([]interface{})),
}

if v, ok := transferSpec["transfer_manifest"].([]interface{}); ok && len(v) > 0 && v[0] != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the need of this block? We already have appropriate validations in the field schema declaration which can handle these cases beforehand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants