Skip to content

Conversation

XianJiChen
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 27 insertions(+))
google-beta provider: Diff ( 3 files changed, 27 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_datascan (15 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_datascan" "primary" {
  data_profile_spec {
    catalog_publishing_enabled = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 63
Passed tests: 63
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dataplex

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 27 insertions(+))
google-beta provider: Diff ( 3 files changed, 27 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_datascan (15 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_datascan" "primary" {
  data_profile_spec {
    catalog_publishing_enabled = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 63
Passed tests: 63
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dataplex

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 285 insertions(+), 22 deletions(-))
google-beta provider: Diff ( 5 files changed, 285 insertions(+), 22 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 285 insertions(+), 22 deletions(-))
google-beta provider: Diff ( 5 files changed, 285 insertions(+), 22 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 64
Passed tests: 62
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexDatascan_dataplexDatascanFullProfileTestExample
  • TestAccDataplexDatascan_dataplexDatascanFullProfile_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexDatascan_dataplexDatascanFullProfileTestExample [Error message] [Debug log]
TestAccDataplexDatascan_dataplexDatascanFullProfile_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 64
Passed tests: 62
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexDatascan_dataplexDatascanFullProfileTestExample
  • TestAccDataplexDatascan_dataplexDatascanFullProfile_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexDatascan_dataplexDatascanFullProfileTestExample [Error message] [Debug log]
TestAccDataplexDatascan_dataplexDatascanFullProfile_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 285 insertions(+), 22 deletions(-))
google-beta provider: Diff ( 5 files changed, 285 insertions(+), 22 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 64
Passed tests: 62
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexDatascan_dataplexDatascanFullProfileTestExample
  • TestAccDataplexDatascan_dataplexDatascanFullProfile_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexDatascan_dataplexDatascanFullProfileTestExample [Error message] [Debug log]
TestAccDataplexDatascan_dataplexDatascanFullProfile_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 285 insertions(+), 22 deletions(-))
google-beta provider: Diff ( 5 files changed, 285 insertions(+), 22 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 64
Passed tests: 62
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexDatascan_dataplexDatascanFullProfileTestExample
  • TestAccDataplexDatascan_dataplexDatascanFullProfile_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexDatascan_dataplexDatascanFullProfileTestExample [Error message] [Debug log]
TestAccDataplexDatascan_dataplexDatascanFullProfile_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants