Skip to content

Conversation

jlmwise
Copy link
Contributor

@jlmwise jlmwise commented Oct 8, 2025

dlp: added `publish_findings_to_dataplex_catalog` field to `google_data_loss_prevention_job_trigger `

@github-actions github-actions bot requested a review from ScottSuarez October 8, 2025 22:17
Copy link

github-actions bot commented Oct 8, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@patrickmoy
Copy link
Member

FYI: Release note needs to be:
dlp: added ...

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 171 insertions(+))
google-beta provider: Diff ( 5 files changed, 171 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 25 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 66
Passed tests: 38
Skipped tests: 0
Affected tests: 28

Click here to see the affected service packages
  • datalossprevention

Action taken

Found 28 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerActionsOptionalExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerBasicExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerBigqueryRowLimitExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerBigqueryRowLimitPercentageExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerChangingActions
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerCloudStorageOptionalTimespanAutopopulationExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerCreateWithTimespanConfigBigQuery
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerDataCatalogOutputExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerDeidentifyExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerDeidentifyUpdate
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerHybridExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerHybridUpdate
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerInspect
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerInspectCustomInfoTypes
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerInspectExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerInspectOptionalExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerJobNotificationEmailsExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerMultipleActionsExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerPublishToDataplexCatalogExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerPublishToStackdriverExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerPubsub
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerSaveToCloudStorage
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerSccOutputExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerTimespanConfigBigQueryExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerUpdateExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerUpdateExample2
  • TestAccDataLossPreventionJobTrigger_dlpJobTriggerWithIdExample
  • TestAccDataLossPreventionJobTrigger_dlpJobTrigger_withSensitivityScore

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataLossPreventionJobTrigger_dlpJobTriggerActionsOptionalExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerBasicExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerBigqueryRowLimitExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerBigqueryRowLimitPercentageExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerChangingActions [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerCloudStorageOptionalTimespanAutopopulationExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerCreateWithTimespanConfigBigQuery [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerDataCatalogOutputExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerDeidentifyExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerDeidentifyUpdate [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerHybridExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerHybridUpdate [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerInspect [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerInspectExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerInspectOptionalExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerJobNotificationEmailsExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerMultipleActionsExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerPublishToDataplexCatalogExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerPublishToStackdriverExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerPubsub [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerSaveToCloudStorage [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerSccOutputExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerTimespanConfigBigQueryExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerUpdateExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerUpdateExample2 [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTriggerWithIdExample [Debug log]
TestAccDataLossPreventionJobTrigger_dlpJobTrigger_withSensitivityScore [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionJobTrigger_dlpJobTriggerInspectCustomInfoTypes [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link

@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for review from other reviewer

Copy link
Member

@patrickmoy patrickmoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScottSuarez Approved, feel free to merge if things look good on your end. (I'm the main point-of-contact on the DLP team for Terraform issues).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants