Skip to content

fix(retail): add region tag for Java - search product with boost spec #10121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(retail): add region tag for Java - search product with boost spec #10121

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b60adfb
Update SearchWithPagination.java
rebeccaellis Jun 11, 2025
24e9ac1
Merge pull request #2 from rebeccaellis/rebeccaellis-patch-search-wit…
rebeccaellis Jun 11, 2025
009b2e2
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 13, 2025
8a99d05
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 17, 2025
50ac4d1
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 27, 2025
7ebb204
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jul 8, 2025
b89b03e
Update SearchWithBoostSpec.java
rebeccaellis Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions retail/interactive-tutorials/src/main/java/search/SearchWithBoostSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@

package search;

// [START retail_search_product_with_boost_spec]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This region tag should include a brief description of the code it surrounds. Consider renaming it to [START retail_search_product_with_boost_spec_example] to better reflect its purpose.

Suggested change
// [START retail_search_product_with_boost_spec]
// [START retail_search_product_with_boost_spec_example]


import com.google.cloud.ServiceOptions;
import com.google.cloud.retail.v2.SearchRequest;
import com.google.cloud.retail.v2.SearchRequest.BoostSpec;
Expand Down Expand Up @@ -79,3 +81,4 @@ public static void searchResponse(String defaultSearchPlacementName) throws IOEx
}
}
}
// [END retail_search_product_with_boost_spec]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This region tag should include a brief description of the code it surrounds. Consider renaming it to [END retail_search_product_with_boost_spec_example] to better reflect its purpose.

Suggested change
// [END retail_search_product_with_boost_spec]
// [END retail_search_product_with_boost_spec_example]