-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(all): update opentelemetry-go monorepo to v1.38.0 #5225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(all): update opentelemetry-go monorepo to v1.38.0 #5225
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the opentelemetry-go monorepo to version v1.35.0. It updates several modules including go.opentelemetry.io/otel, go.opentelemetry.io/otel/metric, go.opentelemetry.io/otel/sdk, go.opentelemetry.io/otel/sdk/metric, go.opentelemetry.io/otel/trace, go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc, and go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc. This change impacts multiple go.mod files across different directories, ensuring consistent versions of the OpenTelemetry libraries are used throughout the project.
Highlights
- Dependency Update: The core change involves updating the
opentelemetry-gomonorepo dependencies to the latest version,v1.35.0. - Module Consistency: The pull request ensures that all relevant modules within the project use the same, updated version of the OpenTelemetry libraries.
- Feature Additions and Fixes: The updated OpenTelemetry version includes new features like
ValueFromAttributeandKeyValueFromAttributeingo.opentelemetry.io/otel/log, and fixes for goroutine leaks ingo.opentelemetry.io/otel/sdk/trace.
Changelog
Click here to see the changelog
- opentelemetry/instrumentation/app/go.mod
- Updated
go.opentelemetry.io/oteltov1.35.0 - Updated
go.opentelemetry.io/otel/metrictov1.35.0 - Updated
go.opentelemetry.io/otel/sdktov1.35.0 - Updated
go.opentelemetry.io/otel/sdk/metrictov1.35.0 - Updated
go.opentelemetry.io/otel/tracetov1.35.0
- Updated
- opentelemetry/trace/go.mod
- Updated
go.opentelemetry.io/oteltov1.35.0 - Updated
go.opentelemetry.io/otel/sdktov1.35.0
- Updated
- pubsub/go.mod
- Updated
go.opentelemetry.io/oteltov1.35.0 - Updated
go.opentelemetry.io/otel/sdktov1.35.0
- Updated
- run/custom-metrics/go.mod
- Updated
go.opentelemetry.io/oteltov1.35.0 - Updated
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpctov1.35.0 - Updated
go.opentelemetry.io/otel/metrictov1.35.0 - Updated
go.opentelemetry.io/otel/sdktov1.35.0 - Updated
go.opentelemetry.io/otel/sdk/metrictov1.35.0
- Updated
- spanner/opentelemetry/go.mod
- Updated
go.opentelemetry.io/oteltov1.35.0 - Updated
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpctov1.35.0 - Updated
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpctov1.35.0 - Updated
go.opentelemetry.io/otel/metrictov1.35.0 - Updated
go.opentelemetry.io/otel/sdktov1.35.0 - Updated
go.opentelemetry.io/otel/sdk/metrictov1.35.0
- Updated
- spanner/opentelemetry/tracing/go.mod
- Updated
go.opentelemetry.io/oteltov1.35.0 - Updated
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpctov1.35.0 - Updated
go.opentelemetry.io/otel/sdktov1.35.0
- Updated
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Trivia time!
What is the primary purpose of OpenTelemetry?
Click here for the answer
OpenTelemetry aims to standardize the generation and collection of telemetry data (metrics, logs, and traces) from software, providing a unified way to observe and understand application behavior.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR updates the opentelemetry-go monorepo to v1.35.0 across multiple modules. The changes primarily involve updating the go.mod files to reflect the new versions of the opentelemetry dependencies. Overall, the update seems straightforward and necessary to keep the project up-to-date with the latest OpenTelemetry features and fixes.
Merge Readiness
The pull request updates the opentelemetry-go monorepo to v1.35.0. Given the nature of the changes (dependency updates), it's crucial to ensure that all tests pass and that the application functions as expected with the new versions. Since there are no critical or high severity issues, I would recommend that the pull request be merged after verifying that all tests pass. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.
98b1b8c to
a39b468
Compare
a39b468 to
621d9f7
Compare
621d9f7 to
50c1f9f
Compare
7b90816 to
0272377
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
|
OK, we're at least only getting failures in opentelemetry tests now. Next step is to investigate the tests. Were these failing before this update? New failure? Etc. Current failure: |
This PR contains the following updates:
v1.34.0->v1.38.0v1.37.0->v1.38.0v1.28.0->v1.38.0v1.28.0->v1.38.0v1.34.0->v1.38.0v1.34.0->v1.38.0v1.37.0->v1.38.0v1.34.0->v1.38.0v1.34.0->v1.38.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
open-telemetry/opentelemetry-go (go.opentelemetry.io/otel)
v1.38.0: /v0.60.0/v0.14.0/v0.0.13Compare Source
Overview
This release is the last to support Go 1.23. The next release will require at least Go 1.24.
Added
go.opentelemetry.io/otel/exporters/prometheus. (#6772)go.opentelmetry.io/otel/semconv/v1.34.0package. (#6939)ContainerLabelDBOperationParameterDBSystemParameterHTTPRequestHeaderHTTPResponseHeaderK8SCronJobAnnotationK8SCronJobLabelK8SDaemonSetAnnotationK8SDaemonSetLabelK8SDeploymentAnnotationK8SDeploymentLabelK8SJobAnnotationK8SJobLabelK8SNamespaceAnnotationK8SNamespaceLabelK8SNodeAnnotationK8SNodeLabelK8SPodAnnotationK8SPodLabelK8SReplicaSetAnnotationK8SReplicaSetLabelK8SStatefulSetAnnotationK8SStatefulSetLabelProcessEnvironmentVariableRPCConnectRPCRequestMetadataRPCConnectRPCResponseMetadataRPCGRPCRequestMetadataRPCGRPCResponseMetadataErrorTypeattribute helper function to thego.opentelmetry.io/otel/semconv/v1.34.0package. (#6962)WithAllowKeyDuplicationingo.opentelemetry.io/otel/sdk/logwhich can be used to disable deduplication for log records. (#6968)WithCardinalityLimitoption to configure the cardinality limit ingo.opentelemetry.io/otel/sdk/metric. (#6996, #7065, #7081, #7164, #7165, #7179)Clonemethod toRecordingo.opentelemetry.io/otel/logthat returns a copy of the record with no shared state. (#7001)go.opentelemetry.io/otel/sdk/trace. Check thego.opentelemetry.io/otel/sdk/trace/internal/xpackage documentation for more information. (#7027, #6393, #7209)go.opentelemetry.io/otel/semconv/v1.36.0package. The package contains semantic conventions from thev1.36.0version of the OpenTelemetry Semantic Conventions. See the migration documentation for information on how to upgrade fromgo.opentelemetry.io/otel/semconv/v1.34.0.(#7032, #7041)WithTranslationStrategyoption ingo.opentelemetry.io/otel/exporters/prometheus. The current default translation strategy when UTF-8 mode is enabled isNoUTF8EscapingWithSuffixes, but a future release will change the default strategy toUnderscoreEscapingWithSuffixesfor compliance with the specification. (#7111)go.opentelemetry.io/otel/sdk/log. Check thego.opentelemetry.io/otel/sdk/log/internal/xpackage documentation for more information. (#7121)go.opentelemetry.io/otel/exporters/stdout/stdouttrace. Check thego.opentelemetry.io/otel/exporters/stdout/stdouttrace/internal/xpackage documentation for more information. (#7133)go.opentelemetry.io/otel/semconv/v1.37.0package. The package contains semantic conventions from thev1.37.0version of the OpenTelemetry Semantic Conventions. See the migration documentation for information on how to upgrade fromgo.opentelemetry.io/otel/semconv/v1.36.0.(#7254)Changed
TraceIDFromHexandSpanIDFromHexingo.opentelemetry.io/otel/sdk/trace. (#6791)AssertEqualingo.opentelemetry.io/otel/log/logtestto acceptTestingTin order to support benchmarks and fuzz tests. (#6908)DefaultExemplarReservoirProviderSelectoringo.opentelemetry.io/otel/sdk/metricto useruntime.GOMAXPROCS(0)instead ofruntime.NumCPU()for theFixedSizeReservoirProviderdefault size. (#7094)Fixed
SetBodymethod ofRecordingo.opentelemetry.io/otel/sdk/lognow deduplicates key-value collections (log.Valueoflog.KindMapfromgo.opentelemetry.io/otel/log). (#7002)go.opentelemetry.io/otel/exporters/prometheusto not append a suffix if it's already present in metric name. (#7088)go.opentelemetry.io/otel/exporters/stdout/stdouttraceself-observability component type and name. (#7195)go.opentelemetry.io/otel/exporters/stdout/stdouttrace. (#7199)Deprecated
WithoutUnitsandWithoutCounterSuffixesoptions, preferringWithTranslationStrategyinstead. (#7111)OTEL_GO_X_CARDINALITY_LIMITenvironment variable ingo.opentelemetry.io/otel/sdk/metric. UseWithCardinalityLimitoption instead. (#7166)What's Changed
96f361dby @renovate[bot] in #7054a45f3dfby @renovate[bot] in #705889aa817by @renovate[bot] in #706117c88fdby @renovate[bot] in #7062ba65ee6by @renovate[bot] in #7068fce6240by @renovate[bot] in #7075846d391by @renovate[bot] in #7078ab8d56dby @renovate[bot] in #70881581f0aby @renovate[bot] in #7096f173205by @renovate[bot] in #709728f32e4by @renovate[bot] in #7099a7a43d2by @renovate[bot] in #71269469f96by @renovate[bot] in #713401f7bf4by @renovate[bot] in #7146e98b521by @renovate[bot] in #7151a408d31by @renovate[bot] in #71586b04f9bby @renovate[bot] in #716951f8813by @renovate[bot] in #7173sdk/metric/xFeature Supporting Cardinality Limits by @ysolomchenko in #71665f3141cby @renovate[bot] in #7176ExportSpansfor measurements instdouttraceby @MrAlias in #7198stdouttraceExporter.initSelfObservabilityintoExporter.Newby @MrAlias in #7197tracer.initSelfObservabilityintoTracerProvider.Tracerby @MrAlias in #7205sdk/trace/internal/xREADME.md by @MrAlias in #7211Distinctdocs by @MrAlias in #7203t.Cleanupinstead ofdeferinstdouttraceby @MrAlias in #7204t.Cleanupinstead ofdeferinsdk/traceby @MrAlias in #7208stdouttraceobservability by @MrAlias in #7199stdouttraceself-observability by @MrAlias in #72013122310by @renovate[bot] in #7216d4663adby @renovate[bot] in #7238logger.initSelfObservabilityintologger.newLoggerrand uset.Cleanupinstead of defer by @yumosx in #7228Float64ObservableCounterwithsystem.CPUTimeby @MrAlias in #7235c5933d9by @renovate[bot] in #7246c5933d9by @renovate[bot] in #7250sdk/traceby @MrAlias in #7209AddSetandRecordSetmethods to semconv generated packages by @MrAlias in #7223semconv/v1.37.0packages by @MrAlias in #7254New Contributors
Full Changelog: open-telemetry/opentelemetry-go@exporters/prometheus/v0.59.1...v1.38.0
v1.37.0: Release 1.37.0/0.59.0/0.13.0Compare Source
Added
go.opentelemetry.io/otel/semconv/v1.33.0package.The package contains semantic conventions from the
v1.33.0version of the OpenTelemetry Semantic Conventions.See the migration documentation for information on how to upgrade from
go.opentelemetry.io/otel/semconv/v1.32.0.(#6799)go.opentelemetry.io/otel/semconv/v1.34.0package.The package contains semantic conventions from the
v1.34.0version of the OpenTelemetry Semantic Conventions. (#6812)otel_scope_schema_urllabel ingo.opentelemetry.io/otel/exporters/prometheus. (#5947)otel_scope_[attribute]labels ingo.opentelemetry.io/otel/exporters/prometheus. (#5947)EventNametoEnabledParametersingo.opentelemetry.io/otel/log. (#6825)EventNametoEnabledParametersingo.opentelemetry.io/otel/sdk/log. (#6825)go.opentelemetry.io/otel/exporters/prometheusmetric renaming to add unit suffixes when it doesn't match one of the pre-defined values in the unit suffix map. (#6839)Changed
v1.26.0tov1.34.0ingo.opentelemetry.io/otel/bridge/opentracing. (#6827)v1.26.0tov1.34.0ingo.opentelemetry.io/otel/exporters/zipkin. (#6829)v1.26.0tov1.34.0ingo.opentelemetry.io/otel/metric. (#6832)v1.26.0tov1.34.0ingo.opentelemetry.io/otel/sdk/resource. (#6834)v1.26.0tov1.34.0ingo.opentelemetry.io/otel/sdk/trace. (#6835)v1.26.0tov1.34.0ingo.opentelemetry.io/otel/trace. (#6836)Record.Resourcenow returns*resource.Resourceinstead ofresource.Resourceingo.opentelemetry.io/otel/sdk/log. (#6864)go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc,go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc,go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc,go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp,go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp,go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp. (#6898)Fixed
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc. (#6710)go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp. (#6710)go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc. (#6710)go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp. (#6710)go.opentelemetry.io/otel/exporters/prometheus. (#6822)go.opentelemetry.io/otel/sdk/metric. (#6914)Removed
go.opentelemetry.io/otel/exporters/prometheusno longer exportsotel_scope_infometric. (#6770)What's Changed
45338d2by @renovate in #6807f0acec6by @renovate in #6810semconv/v1.33.0by @MrAlias in #6799Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.