Skip to content

chore(gemspec): update fluentd >= 1.14.x #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore(gemspec): update fluentd >= 1.14.x #475

wants to merge 3 commits into from

Conversation

Cryptophobia
Copy link
Contributor

@Cryptophobia Cryptophobia commented Sep 13, 2021 •
edited
Loading

  • update fluentd to 1.14.x gem
  • update json to 2.5.1 for CVE-2020-10663
  • upgrade google-protobuf gem to 3.17.3 (same as PR Upgrade google-protobuf to v3.17.3 #465)
  • fix deprecation warnings during rake tests: common.rb:114: warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open

Fluentd changelog for v1.14.x

Signed-off-by: Anton Ouzounov aouzounov@vmware.com

@google-cla google-cla bot added the cla: yes label Sep 13, 2021
@qingling128
Copy link
Contributor

We'd need to carefully measure the performance of these gem version upgrades.

The last attempt to upgrade json gem caused a memory regression and we had to roll it back.

We do know that json 2.4.1 is not safe to upgrade to. They do have a newer version 2.5.1 out though.

@Cryptophobia
Copy link
Contributor Author

Cryptophobia commented Sep 14, 2021 •
edited
Loading

Hi @qingling128 , what version of ruby are you using in your testing environment? Also what version of jemalloc are you using? There are multiple issues with using later than jemalloc v3.6.0 with libmalloc and ruby will cause memory to continue grow (memory leaks) on fluentd. This curious as the above may not be due to actual json gem upgrade but your environment/configuration/docker could also be a factor in the memory regression.

fluent/fluent-package-builder#305

@Cryptophobia
Copy link
Contributor Author

I pushed json 2.5.1 here for testing.

Anton Ouzounov added 2 commits November 10, 2021 13:57
chore: update to fluentd v1.12.3
53051bc 
  - increment gem version for plugin
  - update to allow fluentd v1.12.3 gem
  - update json to 2.4.1 for [CVE-2020-10663](https://www.ruby-lang.org/en/news/2020/03/19/json-dos-cve-2020-10663/)

Signed-off-by: Anton Ouzounov <aouzounov@vmware.com>
chore(gemspec): update fluentd to 1.13.3
2a830e4 
 - update to allow fluentd 1.13.3 gem

Fluentd changelog for [v1.13.2](https://github.com/fluent/fluentd/blob/master/CHANGELOG.md#v1132)
Fluentd changelog for [v1.13.3](https://github.com/fluent/fluentd/blob/master/CHANGELOG.md#v1133)

Signed-off-by: Anton Ouzounov <aouzounov@vmware.com>
@Cryptophobia
Copy link
Contributor Author

This has been rebased with latest from upstream/master and works with ruby 2.7.4 now. Please test. Test seem to fail with ruby 2.4 now.

chore(gemspec): update fluentd >= 1.14.x
00d1253 
 - update fluentd to 1.14.x gem
 - update json gem to 2.5.1
 - fix deprecation warnings during rake tests: `common.rb:114: warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open`

Fluentd changelog for [v1.14.x](https://github.com/fluent/fluentd/blob/master/CHANGELOG.md#v1140)

Signed-off-by: Anton Ouzounov <aouzounov@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Cryptophobia @qingling128