-
-
Notifications
You must be signed in to change notification settings - Fork 354
Add it blame-copy-royal
#2041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add it blame-copy-royal
#2041
Conversation
Thanks for making this happen! Early feedback could be that this seems to be a breaking change in |
039d300
to
6c6c733
Compare
6c6c733
to
01cd9bd
Compare
01cd9bd
to
b01d624
Compare
Implement `Display` for `BlameScriptOperation`
@Byron I think I’ve now reached a point where it makes sense for you to start reviewing! I tried to add as much context as possible in comments. I hope that’s enough context, let me know if you need more! I also tried to have each commit only touch a single crate. Feel free to squash if you want! What I wasn’t sure about was the command’s name. This initial version basically just copies the name from I will continue testing the PR in the background. My gut feeling tells me that, at this point, any issues I might still find could also be issues in the blame implementation itself. |
This is a draft PR. It is mostly intended for early feedback, in case there’s any. I plan on addressing the remaining TODOs over the course of the coming days. I also plan on providing more context. :-)