Add test for rename tracking per hunk #2039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a test case for the issue fixed in 7435ed5. The issue was related to the fact that, before the fix, `source_file_name` was only tracked globally, as opposed to locally, i. e. on a per-hunk basis. The test case constructs a repository that has the same rename twice, in two different branches. Tracking `source_file_name` globally is insufficient to capture this history which is why this test fails without the fix.
Byron
force-pushed
the
add-test-for-rename-tracking
branch
from
932eaea to
8e2bc0f
Compare
Byron
approved these changes
Jun 9, 2025
There was a problem hiding this comment.
Thanks a lot, much appreciated!
I have started to move fixture scripts from verbose echo 'line1\nline2\n' to seq X Y and hope that other code here is also eligible for that.
Finally, I thought that now that tests stabilise, one could replace .unwrap() with ?, but didn't do that myself in the interest of time (and in feat this would also turn Option::unwrap() into ? and fail (these could then be .expect()).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test case for the issue fixed in 7435ed5. The issue was related to the fact that, before the fix,
source_file_namewas only tracked globally, as opposed to locally, i. e. on a per-hunk basis.The test case constructs a repository that has the same rename twice, in two different branches. Tracking
source_file_nameglobally is insufficient to capture this history which is why this test fails without the fix.