Set System.Collections.Immutable as a private asset #4594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reorders the PackageReference for System.Collections.Immutable so that it is correctly picked up as a private asset.
- Moves the System.Collections.Immutable reference above the global PrivateAssets update group
- Removes a duplicate or misplaced reference to System.Collections.Immutable
| @@ -17,9 +17,9 @@ | |||
| <PackageReference Include="Microsoft.Build.Utilities.Core" /> | |||
| <PackageReference Include="Microsoft.Win32.Registry" /> | |||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection" /> | |||
| <PackageReference Include="System.Collections.Immutable" /> | |||
There was a problem hiding this comment.
[nitpick] The current reference for System.Collections.Immutable is added without an explicit PrivateAssets attribute. Although the global update applies PrivateAssets to all PackageReferences, adding a comment here to explain this behavior could enhance code clarity.
Suggested change
| <PackageReference Include="System.Collections.Immutable" /> | |
| <PackageReference Include="System.Collections.Immutable" PrivateAssets="All" /> | |
| <!-- Explicitly specifying PrivateAssets="All" here for clarity, even though the global update applies it to all PackageReferences. --> |
Copilot uses AI. Check for mistakes.
2 tasks
|
Thank you @joao-genebra for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the order in which
System.Collections.Immutableis referenced to ensure that it is set as a private assetRelated Issue
#4593
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: