Fix Directory.Build.props #4586
Conversation
…ame.EndsWith (was invalid syntax so NCrunch was broken and VS was padlock unhappy if tolerant)
|
Marked draft; don't think it has helped after all and NCRUNCH is no closer to running. Will either resubmit or delete... |
| <DisableApiAnalyzers>false</DisableApiAnalyzers> | ||
| <IsUnitTestProject Condition="$(MSBuildProjectName.EndsWith('.Tests')) or $(MSBuildProjectName.EndsWith('.Testing'))">true</IsUnitTestProject> | ||
| <IsUnitTestProject Condition="'$(MSBuildProjectName)' != '' and ($([System.String]::Copy($(MSBuildProjectName)).EndsWith('.Tests')) Or $([System.String]::Copy($(MSBuildProjectName)).EndsWith('.Testing')))">true</IsUnitTestProject> |
There was a problem hiding this comment.
May I ask why you need to copy the Project name?
There was a problem hiding this comment.
NCrunch doesn't get the reference VS infers from directory props. Investigating I conflated the change in this PR with another I had also made to the csproj (ref present not inferred); the hypothesis that the ms build syntax was invalid. PR proposed. Further pressing on NCrunch exposed my mistake so I withdrew to draft. Sorry for the misdirect; I don't think this one's got legs.
FWIW the best I've come up with to get NCrunch functional is to messily bypass Ncrunch's problems with Core[.Testing] and relocate the immediate coverage that's directly useful. Far from ideal so apologies for relying on CI run feedback for the rest. 😇
|
Closing - not fit for purpose. |
Description
Fix IsUnitTestProject (cannot be specified twice) and MSBuildProjectName.EndsWith (was invalid syntax so NCrunch was broken and VS was padlock unhappy if tolerant)
Related Issue
Motivation and Context
VS2022 wasn't happy and nCrunch wasn't building at all.
How Has This Been Tested?
With the fix VisualStudio is happy again, but unfortunately NCrunch still isn't and that was really what I was aiming for. I'll propose the VisualStudio fix at least for now. If you know how to fix NCrunch please do let me know. I could see quite a few years ago there were some Issues raised to get NCrunch running again so hopefully someone's in the know?
Screenshots (if appropriate):
Checklist: