Skip to content

(deps): Bump Buildalyzer from 6.0.4 to 7.0.1 #4025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions GitVersion.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
workflow: GitFlow/v1
mode: ManualDeployment
branches:
main:
label: beta
Expand Down
2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"src"
],
"sdk": {
"version": "8.0.203"
"version": "8.0.300"
}
}
2 changes: 1 addition & 1 deletion src/Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<PackageVersion Include="Roslynator.Analyzers" Version="4.12.2" />
<PackageVersion Include="Roslynator.Formatting.Analyzers" Version="4.12.2" />
<!-- specific packages -->
<PackageVersion Include="Buildalyzer" Version="6.0.4" />
<PackageVersion Include="Buildalyzer" Version="7.0.1" />
<PackageVersion Include="JsonSchema.Net.Generation" Version="4.3.0.2" />
<PackageVersion Include="JunitXml.TestLogger" Version="3.1.12" />
<PackageVersion Include="MSBuild.ProjectCreation" Version="12.0.1" />
Expand Down
2 changes: 1 addition & 1 deletion src/GitVersion.App/ArgumentParserExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public static bool ArgumentRequiresValue(this string argument, int argumentIndex

var argumentMightRequireValue = !booleanArguments.Contains(argument[1..], StringComparer.OrdinalIgnoreCase);

// If this is the first argument that might be a target path, the argument starts with slash and we're on an OS that supports paths with slashes, the argument does not require a value.
// If this is the first argument that might be a target path, the argument starts with slash, and we're on an OS that supports paths with slashes, the argument does not require a value.
if (argumentMightRequireValue && argumentIndex == 0 && argument.StartsWith('/') && Path.DirectorySeparatorChar == '/' && argument.IsValidPath())
return false;

Expand Down
2 changes: 1 addition & 1 deletion src/GitVersion.App/QuotedStringHelpers.cs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public static string UnquoteText(string input)
if (sb[0] == '"')
sb.Remove(0, 1);

if (sb[sb.Length - 1] == '"' && sb[sb.Length - 2] != '\\')
if (sb[^1] == '"' && sb[^2] != '\\')
sb.Remove(sb.Length - 1, 1);

sb.Replace("\\\"", "\""); // unescape quotes.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public void SourceBranchesValidationShouldSucceedForWellKnownBranches(string wel
using var _ = this.fileSystem.SetupConfigFile(path: this.repoPath, text: text);
var configuration = this.configurationProvider.ProvideForDirectory(this.repoPath);

configuration.Branches["bug"].SourceBranches.ShouldBe(new List<string> { wellKnownBranchKey });
configuration.Branches["bug"].SourceBranches.ShouldBe([wellKnownBranchKey]);
}

[Test]
Expand Down Expand Up @@ -301,7 +301,7 @@ public void ShouldUseSpecifiedSourceBranchesForDevelop()
using var _ = this.fileSystem.SetupConfigFile(path: this.repoPath, text: text);
var configuration = this.configurationProvider.ProvideForDirectory(this.repoPath);

configuration.Branches["develop"].SourceBranches.ShouldBe(new List<string> { "develop" });
configuration.Branches["develop"].SourceBranches.ShouldBe(["develop"]);
}

[Test]
Expand Down Expand Up @@ -332,7 +332,7 @@ public void ShouldUseSpecifiedSourceBranchesForFeature()
using var _ = this.fileSystem.SetupConfigFile(path: this.repoPath, text: text);
var configuration = this.configurationProvider.ProvideForDirectory(this.repoPath);

configuration.Branches["feature"].SourceBranches.ShouldBe(new List<string> { "develop", "release" });
configuration.Branches["feature"].SourceBranches.ShouldBe(["develop", "release"]);
}

[Test]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
namespace GitVersion.Configuration.Attributes;

/// <summary>
/// <para>The <c>format</c> keyword allows for basic semantic identification of certain kinds of string values that are commonly used. For example, because JSON doesn't have a "DateTime" type, dates need to be encoded as strings. <c>format</c> allows the schema author to indicate that the string value should be interpreted as a date. By default, <c>format</c> is just an annotation and does not effect validation.</para>
/// <para>The <c>format</c> keyword allows for basic semantic identification of certain kinds of string values that are commonly used. For example, because JSON doesn't have a "DateTime" type, dates need to be encoded as strings. <c>format</c> allows the schema author to indicate that the string value should be interpreted as a date. By default, <c>format</c> is just an annotation and does not affect validation.</para>
/// <para>Optionally, validator implementations can [...] enable <c>format</c> to function as an assertion rather than just an annotation.</para>
/// <see href="https://json-schema.org/understanding-json-schema/reference/string#format"/>
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ internal class PreventIncrementConfiguration : IPreventIncrementConfiguration
public bool? WhenBranchMerged { get; set; }

[JsonPropertyName("when-current-commit-tagged")]
[JsonPropertyDescription("This branch related property controls the behvior whether to use the tagged (value set to true) or the incremented (value set to false) semantic version. Defaults to true.")]
[JsonPropertyDescription("This branch related property controls the behavior whether to use the tagged (value set to true) or the incremented (value set to false) semantic version. Defaults to true.")]
public bool? WhenCurrentCommitTagged { get; set; }
}
3 changes: 1 addition & 2 deletions src/GitVersion.Core.Tests/Helpers/TestFileSystem.cs
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,9 @@ public void WriteAllText(string? file, string fileContents, Encoding encoding)
public Stream OpenRead(string path)
{
var fullPath = Path.GetFullPath(path);
if (!this.fileSystem.ContainsKey(fullPath))
if (!this.fileSystem.TryGetValue(fullPath, out var content))
throw new FileNotFoundException("File not found.", fullPath);

var content = this.fileSystem[fullPath];
return new MemoryStream(content);
}

Expand Down
Loading
Loading