(maint) Move common project properties to Directory.Build.props #662
Conversation
arturcic
force-pushed
the
feature/common-props
branch
from
a4eba97 to
943405a
Compare
|
@gep13 updated, please have a new look |
|
would be nice if you can give it locally a try as well. |
|
@arturcic the changes themselves here look good, but something is going on with the CI build, that I will need to take a look at. Leave it with me, and I will get back to you if/when I find something. |
Sure, |
|
@arturcic apologies on not getting back to you sooner about this PR, I have only just now had a chance to look at this. Unfortunately, we are not going to be able to move forward with merging this PR, even though I can see the benefit of it 😢 Cake.Recipe currently relies on the Target Frameworks being defined within the csproj file, as can be seen here: Since these have been moved into the common file, the csproj parsing that is currently done can't find that information, and as a result, the To fix this, we would need to update Cake.Recipe to additionally parse the common file looking for targetframworks, if none can be found in the csproj file. |
|
For now, I am going to remove this PR from the 0.19.0 milestone. |
arturcic
force-pushed
the
feature/common-props
branch
from
943405a to
6c7a331
Compare
arturcic
force-pushed
the
feature/common-props
branch
from
6c7a331 to
824a53d
Compare
|
hey @gep13 I guess this can be merged, I moved back to the csproj only the TargetFrameworks, but I kept all the other common properties. |
gep13
changed the title
|
@arturcic thanks for getting this PR uppdated! At some point, although I can't say when, it would be great to be able to use the Directory.Build.props for the TargetFrameworks as well, but as it is currently written, the build process can't make use of it 😢 |
|
🎉 This issue has been resolved in version 0.20.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
This should improve the maintenance of the common properties. When we upgrade to .net80 and .net90, that will be much simpler