Skip to content

Bump NUnit from 3.14.0 to 4.1.0 in /src #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 11, 2024

Bumps NUnit from 3.14.0 to 4.1.0.

Release notes

Sourced from NUnit's releases.

NUnit 4.1.0

See release notes

NUnit 4.0.1

Patch release to fix windows targets

See release notes and See migration guide

NUnit 4.0.0

See release notes and See migration guide

NUnit 4.0.0-beta.1

See release notes and information

Changelog

Sourced from NUnit's changelog.

For further changes, see release notes


NUnit 4.0.0 - November 26, 2023

All changes, see release notes

NUnit 4.0.0-beta.1 - October 8, 2023

This release is the first beta release of NUnit 4.0. All changes, see release notes

NUnit 3.13.2 - April 27, 2021

This release fixes a new issue with the FixtureLifeCycle attribute where IDisposable test fixtures were not being disposed properly. As always, @​gleb-osokin has been a great help with this new feature.

It also fixes a long-standing performance issue with CollectionAssert.AreEquivalent and the CollectionEquivalentConstraint when comparing large collections. The deep comparison that NUnit performs on the two collections will always have a worst case bound of O(n^2) but we have optimized it so that the majority of use cases will be closer to O(n).

We've also made significant optimizations to the OR filters for selecting tests using their full name. This dramatically improves test performance for large code bases that use dotnet test. Thanks to @​pakrym for his help with this.

Issues Resolved

  • 2799 CollectionAssert.AreEquivalent is extremely slow
  • 3589 File headers, copyrights, and licenses
  • 3773 IDisposable not working with InstancePerTestCase
  • 3779 Obsolete AreEqual methods with nullable numeric arguments for 3.13
  • 3784 Build the v3.13-dev branch
  • 3786 NUnit with dotnet test results in O(n^2) filtering complexity
  • 3810 Enable deterministic build
  • 3818 AppVeyor failing to build v3.13-dev branch PRs
  • 3832 Deploy v3.13-dev branch builds to MyGet

NUnit 3.13.1 - January 31, 2021

This release addresses several misses with the new FixtureLifeCycle attribute, switches to using SourceLink and NuGet snupkg packages for debugging into NUnit from your unit tests. It also addresses issues with the time format of ignored and explicit tests in the test results file.

Issues Resolved

  • 2339 Wrong date format in Ignored TestFixtures
  • 3715 FixtureLifeCycle(LifeCycle.InstancePerTestCase) Not working with TestFixtureSource
  • 3716 Assembly level FixtureLifeCycle(LifeCycle.InstancePerTestCase) doesn't work
  • 3724 Test start and end time should end with Z
  • 3726 Assert EqualTo().Within().Seconds does not work with DateTimes in NUnit 3.13
  • 3729 AppVeyor builds failing
  • 3736 AreEqual.Within throws on failure with non-numeric types
  • 3743 Parametrized tests do not respect FixtureLifeCycle.InstancePerTestCase
  • 3745 After upgrading to NUnit 3.13.0 the debugger enters NUnit code despite having checked "Enable Just My Code"

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 11, 2024
@arturcic
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/nuget/src/NUnit-4.1.0 branch from d8ecfe7 to d086d07 Compare July 10, 2024 02:43
@gep13
Copy link
Member

gep13 commented Jul 10, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/nuget/src/NUnit-4.1.0 branch from d086d07 to 7d348d3 Compare July 10, 2024 08:10
@gep13
Copy link
Member

gep13 commented Jul 10, 2024

@dependabot rebase

@arturcic
Copy link
Member

@gep13 I think this PR requires code adjustments as well for the new syntax for Assert

Bumps [NUnit](https://github.com/nunit/nunit) from 3.14.0 to 4.1.0.
- [Release notes](https://github.com/nunit/nunit/releases)
- [Changelog](https://github.com/nunit/nunit/blob/master/CHANGES.md)
- [Commits](nunit/nunit@v3.14.0...4.1.0)

---
updated-dependencies:
- dependency-name: NUnit
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/src/NUnit-4.1.0 branch from 7d348d3 to 6c415bd Compare July 10, 2024 09:57
@gep13
Copy link
Member

gep13 commented Jul 10, 2024

@arturcic said...
I think this PR requires code adjustments as well for the new syntax for Assert

Yes, it does. I have just added the NUnit.Analyzers package to the projects, and ran through some of its check/fixes. Rebasing this PR again against develop where I made those changes, to see if it enough to get this over the line.

This no longer exists in NUnit 4.x.
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 enabled auto-merge July 10, 2024 10:08
@gep13 gep13 added Build and removed dependencies Pull requests that update a dependency file labels Jul 10, 2024
@gep13 gep13 added this to the 0.18.0 milestone Jul 10, 2024
@gep13 gep13 merged commit 8c41f54 into develop Jul 10, 2024
2 checks passed
@gep13 gep13 deleted the dependabot/nuget/src/NUnit-4.1.0 branch July 10, 2024 10:15
gittools-bot pushed a commit that referenced this pull request Jul 10, 2024
Merge pull request #583 from GitTools/dependabot/nuget/src/NUnit-4.1.0

Bump NUnit from 3.14.0 to 4.1.0 in /src
@gittools-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.18.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants