Skip to content

fix(login): add explicit type="submit" to form button #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

stabldev
Copy link
Member

Buttons normally have type="submit" by default, but in some browsers, this doesn't seem to work as expected.
Explicitly adding submit type to prevent this unexpected behaviours.

Fixes #15

@stabldev stabldev changed the title fix(login): add explicit type=submit to form button fix(login): add explicit type="submit" to form button Jun 11, 2025
@stabldev stabldev merged commit 9e528c9 into GitLoomLabs:main Jun 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(login): form requires explicit type="submit" on button to trigger GitHub auth
1 participant